set total forecast time to be real #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2020
|
Thanks! This change has been overdue. |
climbfuji
approved these changes
Sep 22, 2020
|
Dom, thanks for reviewing it. We need to test this branch for LAM and HAFS
to confirm it works for high resolution runs before we run RT and commit
the code.
…On Tue, Sep 22, 2020 at 3:31 PM Dom Heinzeller ***@***.***> wrote:
***@***.**** approved this pull request.
I haven't tested it, but it looks ok to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#81 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TOTBQXLGB2463LTW6DSHD3QZANCNFSM4RVGEJDQ>
.
|
DusanJovic-NOAA
approved these changes
Sep 22, 2020
|
@junwang-noaa, Is this PR ready for merge? |
|
Minsuk,
I am running RT, it is supposed to be committed with ufs-weather-model PR
#206.
…On Mon, Nov 2, 2020 at 11:01 AM Minsuk Ji ***@***.***> wrote:
@junwang-noaa <https://github.com/junwang-noaa>, Is this PR ready for
merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#81 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TN2VKPKRZZVECKNCHLSN3JVFANCNFSM4RVGEJDQ>
.
|
|
Minsuk, All the RTs are done. You can merge the PR. Thanks
On Mon, Nov 2, 2020 at 11:21 AM Jun Wang - NOAA Federal <jun.wang@noaa.gov>
wrote:
… Minsuk,
I am running RT, it is supposed to be committed with ufs-weather-model PR
#206.
On Mon, Nov 2, 2020 at 11:01 AM Minsuk Ji ***@***.***>
wrote:
> @junwang-noaa <https://github.com/junwang-noaa>, Is this PR ready for
> merge?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#81 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AI7D6TN2VKPKRZZVECKNCHLSN3JVFANCNFSM4RVGEJDQ>
> .
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set total forecast time to be real number to allow flexible forecast time
Related PRs:
fv3 PR #175
NEMS PR #81
ufs-weather-model PR #206