Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST PR: confirming new .workflows/*yml changes working as expected in GitHub runner #239

Closed
wants to merge 27 commits into from

Conversation

jbathegit
Copy link
Collaborator

@jbathegit jbathegit commented Nov 17, 2022

see NOAA-EMC/NCEPLIBS-grib_util#165 for more details of the impetus behind this change

@jbathegit jbathegit changed the title R8wraps TEST PR: confirming new .workflows/*yml changes working as expected in GitHub runner Nov 17, 2022
@edwardhartnett
Copy link
Contributor

Not sure what you are doing in this PR.

Code coverage is working in the develop branch currently, I just checked with a test PR.

@jbathegit
Copy link
Collaborator Author

This r8wraps branch is a working branch (nearly finished) to resolve #78. But then when I saw your NOAA-EMC/NCEPLIBS-grib_util#165 notes a couple of weeks ago, I tried to incorporate those same changes into main.yml and main_new.yml, and I submitted this test PR to make sure that it removed the "on push" tests, and that's when gcovr suddenly stopped working altogether!?

I realize your recent yml changes are working in the updated develop branch, so I realize this is ultimately on me and/or Jack to resolve, but this is really puzzling to me why gcovr suddenly has a problem parsing our revised test codes, as noted in #240.

@edwardhartnett
Copy link
Contributor

Are you still having problems with gcovr? It is working in the develop branch. (Not for python - is that what you are trying to achieve?)

@jbathegit
Copy link
Collaborator Author

jbathegit commented Dec 12, 2022

No, I'm not still having problems with gcovr. That went away once I stopped trying to run it on the ../test codes.

The issue I'm having now is with one of the modified test codes (the last one, in fact) failing on MacOS. But it only fails on MacOS and nowhere else, and I don't have a MacOS platform of my own to run this on locally and hook up a debugging tool, so I have to resort to pushing up commits with temporary print statements and use the GitHub runner to try to sort out what's going on here.

@jbathegit
Copy link
Collaborator Author

Now, that this is working, I'll open a formal PR to merge this branch and close the underlying issue.

@jbathegit jbathegit closed this Dec 14, 2022
@jbathegit jbathegit deleted the r8wraps branch December 16, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants