Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add '-c' on Apple systems when using llvm-ranlib #189

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Do not add '-c' on Apple systems when using llvm-ranlib #189

merged 2 commits into from
Apr 4, 2022

Conversation

climbfuji
Copy link
Contributor

Fixes #188.

Tested on macOS with apple-clang + gfortran and with llvm-clang + gfortran:

  • the apple-clang + gfortran config has the -c flag for the ranlib step, all 21 tests pass
  • the llvm-clang + gfortran config does not have the -c flag for the ranlib step, all 21 tests pass

@jbathegit jbathegit mentioned this pull request Feb 8, 2022
Closed
@climbfuji
Copy link
Contributor Author

@kgerheiser @edwardhartnett How do we proceed from here? Kyle approved the PR, but several of the ci tests failed due to changes that are not related to this PR I think. Thanks!

@climbfuji climbfuji mentioned this pull request Mar 4, 2022
Closed
@jbathegit jbathegit merged commit 018441a into NOAA-EMC:develop Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgerheiser kgerheiser kgerheiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patch for adding -c to ranlib flags must not be applied when using llvm-ranlib
3 participants
@climbfuji @kgerheiser @jbathegit