update MOM6 to its main 20231218 commit (disable FPEs) #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to poor handling of floating point in HDF5 1.14.3, it is currently not possible to use floating point exceptions (FPEs) whenever this version is present. The GitHub Actions CI nodes would randomly select either 1.14.2 or 1.14.3, and would raise an FPE error if 1.14.3 was selected. Additionally, the homebrew installation does not provide a clean method for selecting a different version of HDF5. Thus, for now we disable FPEs in the MacOS testing, and hope to catch any legitimate FP errors in the Ubuntu version. We will restore these tests as soon as this has been fixed in an easily-accessible version of HDF5. As part of this PR, I have also moved the FCFLAGS configuration to the platform specific Actions files, allowing for independent compiler configuration for each platform.
Disable FPEs in MacOS testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/emc #124 +/- ##
========================================
Coverage 37.91% 37.91%
========================================
Files 269 269
Lines 77155 77089 -66
Branches 14164 14154 -10
========================================
- Hits 29252 29230 -22
+ Misses 42625 42582 -43
+ Partials 5278 5277 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 7, 2024
|
@DeniseWorthen @JessicaMeixner-NOAA can you review this PR ? |
JessicaMeixner-NOAA
approved these changes
Jan 11, 2024
DeniseWorthen
approved these changes
Jan 11, 2024
|
Tests are done at ufs-community/ufs-weather-model#2080. @DeniseWorthen @JessicaMeixner-NOAA can you merge this pr? |
|
@jiandewang can you do the merge? |
|
just merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOM6 main repository was updated on 20231218 to fix FPEs bug in its CI test. (see detail at mom-ocean#1617). This is a very simple PR with no any resuls change. Related dev/emc MOM6 issue is #123. We need to have this being merged to dev/emc before we can create PR to push @DeniseWorthen work back to main repository.