use ungridded dimension for pstokes #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
|
@DeniseWorthen I assume you received several email on codecov failure for your branch here, this is due to the recent change on github side, Alistair has found the solution and the fixing is in dev/gfdl now but not in dev/emc or its main branch yet. See detail at NOAA-GFDL#270. |
DeniseWorthen
force-pushed
the
feature/pstokes
branch
from
7b22a90
to
30f7d3b
Compare
|
changes look fine to me, let me know when it's time to do the merging |
JessicaMeixner-NOAA
approved these changes
Jan 4, 2023
jiandewang
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements use of ungridded dimensions for the partitioned stokes drift by removing the exchange of 6 individual fields in favor of 2 fields containing 3 ungridded dimensions each.
See UWM Issue #1526