Add/fix build capability for Gaea-C5, Gaea-C6, and container #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks OK to me.
Two comments:
- I can't test the container.
- Additional changes are needed to run GSI/EnKF ctests on Gaea-C6. @DavidBurrows-NCO , do you plan on adding these changes to this PR or will a new issue and PR be opened to activate GSI/EnKF ctests on Gaea-C6?
| @@ -155,7 +155,11 @@ target_link_libraries(gsi_fortran_obj PUBLIC nemsio::nemsio) | |||
| target_link_libraries(gsi_fortran_obj PUBLIC ncio::ncio) | |||
| target_link_libraries(gsi_fortran_obj PUBLIC w3emc::w3emc_d) | |||
| target_link_libraries(gsi_fortran_obj PUBLIC sp::sp_d) | |||
| target_link_libraries(gsi_fortran_obj PUBLIC bufr::bufr_d) | |||
| if(DEFINED ENV{USE_BUFR4}) | |||
There was a problem hiding this comment.
Looks OK to me. Cross checking with @DavidHuber-NOAA . PR #791 upgrades to bufr/12.1.0. Not sure how the bufr logic added here might impact Dave's PR.
|
@RussTreadon-NOAA Thanks for taking a look
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #799
Type of change
How Has This Been Tested?
Cloned and built on Gaea-C5, Gaea-C6, and in a container.
Checklist