Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add safeguard to thompson_reff #779

Merged
merged 2 commits into from
Aug 12, 2024
Merged

add safeguard to thompson_reff #779

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
408917e
remove debug print, check ni and nr prior to calculation (#777)
RussTreadon-NOAA Aug 9, 2024
9a3a90d
use 1e-6 as lower threshold for ni and nr (#777)
RussTreadon-NOAA Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/gsi/crtm_interface.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1206,7 +1206,6 @@ subroutine call_crtm(obstype,obstime,data_s,nchanl,nreal,ich, &
real(r_kind) :: lai

m1=mype+1
if (mype==0) write(6,*) myname_, ' imp_physics = ', imp_physics
if (n_clouds_fwd_wk>0) hwp_guess=zero
hwp_total=zero
theta_700=zero
Expand Down Expand Up @@ -2715,15 +2714,17 @@ subroutine calc_thompson_reff(rho_air,tsen,qxmr,cloud_name,reff)
real(r_kind), parameter :: reff_i_min = 2.5_r_kind ! previous value was 10_r_kind
real(r_kind), parameter :: reff_i_max = 250.0_r_kind ! previous value was 150_r_kind
real(r_kind), parameter:: mu_i = 0.0_r_kind
real(r_kind), parameter:: ni_min = 1.0e-6_r_kind ! minimum number concentration (ccpp-physics)

! Parameters for rain (Lin 1983)
real(r_kind), parameter :: rho_r = 1000.0_r_kind ! [kg/m3 ]
real(r_kind), parameter :: reff_r_min = 50.0_r_kind ! [micron] ! previous value was 0.0_r_kind
real(r_kind), parameter :: reff_r_max = 1000.0_r_kind ! [micron] ! previous value was 10000.0_r_kind
real(r_kind), parameter :: reff_r_min = 50.0_r_kind ! [micron] ! previous value was 0.0_r_kind
real(r_kind), parameter :: reff_r_max = 1000.0_r_kind ! [micron] ! previous value was 10000.0_r_kind
real(r_kind), parameter:: mu_r = 0.0_r_kind
! Parameters for snow
real(r_kind), parameter :: reff_s_min = 5.0_r_kind ! [micron] ! previous value was 0.0_r_kind
real(r_kind), parameter :: reff_s_max = 5000.0_r_kind ! [micron] ! previous value was 10000.0_r_kind
real(r_kind), parameter :: reff_s_max = 5000.0_r_kind ! [micron] ! previous value was 10000.0_r_kind
real(r_kind), parameter:: nr_min = 1.0e-6_r_kind ! minimum number concentration (ccpp-physics)

!For snow moments conversions (from Field et al. 2005)
real(r_kind), dimension(10), parameter:: &
Expand Down Expand Up @@ -2769,10 +2770,10 @@ subroutine calc_thompson_reff(rho_air,tsen,qxmr,cloud_name,reff)
reff_max = reff_i_max
do k = 1, nsig
qx = qxmr(k) * rho_air(k) ! convert mixing ratio (kg/kg) to water content (kg/m3)
if (qx > qmin) then
if (qx > qmin .and. ni(k)>ni_min) then
lam_i=exp(1.0_r_kind / 3.0_r_kind * log((am_i*ni(k) *gamma(mu_i + 3.0_r_kind + 1.0_r_kind))/(qx*gamma(mu_i+1.0_r_kind))))
reff(k) = 0.5_r_kind * (3.0_r_kind /lam_i)*1.0e6_r_kind
reff(k) = max(reff_min, min(reff_max, reff(k)))
reff(k) = 0.5_r_kind * (3.0_r_kind /lam_i)*1.0e6_r_kind
reff(k) = max(reff_min, min(reff_max, reff(k)))
else
reff(k) = zero
endif
Expand All @@ -2784,7 +2785,7 @@ subroutine calc_thompson_reff(rho_air,tsen,qxmr,cloud_name,reff)
reff_max = reff_r_max
do k = 1, nsig
qx = qxmr(k) * rho_air(k) ! convert mixing ratio (kg/kg) to water content (kg/m3)
if (qx > qmin) then
if (qx > qmin .and. nr(k)>nr_min) then
lam_r=exp(1.0_r_kind / 3.0_r_kind * log ((am_r*nr(k) *gamma(mu_r + 3.0_r_kind + 1.0_r_kind))/(qx*gamma(mu_r + 1.0_r_kind))))
reff(k) = 0.5_r_kind *(3.0_r_kind/lam_r)*1.0e6_r_kind
reff(k) = max(reff_min, min(reff_max, reff(k)))
Expand Down
Loading