changes to allow GSI to compile on GAEA #592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SamuelTrahanNOAA - |
|
@SamuelTrahanNOAA , is this PR still relevant now that PR #571 has been merged into develop? If this PR contains changes we need in develop, please update |
|
Thank you @SamuelTrahanNOAA for the quick reply. Shall we close this draft PR? You can open a new PR when the C5 port is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The modulefile and build logic for GAEA are out-of-date, so GSI cannot compile there. This PR updates the gsi_gaea.lua modulefile to use the same libraries as the ufs-weather-model. Also, it disables MKL on GAEA by default, to avoid a link-time error when Cray libsci conflicts with MKL. Only the build.sh disables it by default; the default in CMakeLists.txt is unchanged.
This is a draft because I cannot run jobs on GAEA. Until I can, I have no way to know if this build actually works.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
All I know is that it compiles; I don't know if it runs. That's why this is still a draft. I'm still waiting for access to a project that lets me submit jobs on GAEA.
I don't know how to run the GSI regression tests, so I haven't done that either. Only GAEA-specific parts of the scripts have changed. It should be impossible for these changes to break other platforms. The impossible has been known to happen, so it would be best to test anyway.
Checklist