Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2m hofx #557

Merged
merged 173 commits into from
Jun 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
173 commits
Select commit Hold shift + click to select a range
c947c7e
updates to handle overlow of 32 bit integers, make code run in debug …
jswhit2 Sep 18, 2020
e623476
update to include RTPS inflation
jswhit2 Sep 19, 2020
df517d0
add 'write_ensmean'
jswhit2 Oct 9, 2020
27cba66
require use_qsatmean=T if pseudo_rh=T when write_ensmean=T
jswhit2 Oct 9, 2020
55c6373
update
jswhit2 Oct 9, 2020
2c5a7a4
write out ens mean increment
jswhit2 Oct 9, 2020
8b8673e
GitHub Issue NOAA-EMC/GSI#2 merge release/gfsda.v16.0.0 at 1d3e30a i…
RussTreadon-NOAA Oct 15, 2020
348b88c
don't append hour string unless fhr > 0
jswhit2 Oct 20, 2020
c280826
add some comments
jswhit2 Oct 20, 2020
56062d9
Merge branch 'master' into feature/enkf-64bit
jswhit2 Oct 20, 2020
e045e30
remove openmp parallel regions that were causing problems on orion
jswhit2 Oct 23, 2020
158fa32
utility for 'partial' recentering
jswhit2 Nov 4, 2020
54a1470
update
jswhit2 Nov 5, 2020
c988929
Merge remote-tracking branch 'upstream/master'
jswhit2 Nov 6, 2020
87946df
merge from upstream master
jswhit2 Nov 6, 2020
a79f3e4
Merge branch 'master' into feature/enkf-64bit
jswhit2 Nov 6, 2020
582a612
add beta_e0 parameter
jswhit2 Nov 21, 2020
61b5da6
Merge remote-tracking branch 'upstream/master'
jswhit2 Nov 24, 2020
80c366d
Merge branch 'master' into feature/enkf-64bit
jswhit2 Nov 24, 2020
e10a6c0
port 2mda changes from Clara's fork
jswhit2 Nov 24, 2020
e03361a
initial updates for global_2mDA
jswhit2 Nov 24, 2020
f2ab573
update
jswhit2 Dec 4, 2020
605cc9d
Merge remote-tracking branch 'upstream/master'
jswhit2 Dec 24, 2020
09323b2
Merge branch 'master' into feature/enkf-64bit
jswhit2 Dec 24, 2020
92083c1
Merge remote-tracking branch 'upstream/master' into feature/2mDA
jswhit2 Dec 29, 2020
60efefc
fix bugs in readconvobs
jswhit2 Dec 31, 2020
b104c54
update
jswhit2 Jan 2, 2021
7251918
add writeincrement_2mDA
jswhit2 Jan 6, 2021
f6dceea
don't divide obs by sat humidity if global_2mDA
jswhit2 Jan 6, 2021
4e53545
uncomment diagnostic print
jswhit2 Jan 10, 2021
7548c9e
Merge remote-tracking branch 'upstream/master'
jswhit2 Jan 21, 2021
c916148
Merge branch 'master' into feature/enkf-64bit
jswhit2 Jan 21, 2021
b3f9c74
Changed soil update variables from soilw to slc (liquid only)
ClaraDraper-NOAA Feb 6, 2021
b64167c
Changed soil update variables from soilw to slc (liquid only)
ClaraDraper-NOAA Feb 6, 2021
d41d574
add taper for stratospheric humidity increment
jswhit2 Feb 19, 2021
c99edaa
taper_strat
jswhit2 Feb 22, 2021
ba08bc9
read in first guess separately for enkf and var
jswhit2 Feb 22, 2021
aa268a4
fix bug introduced in last commits
jswhit2 Feb 22, 2021
1ba7ae7
fix delz increment calculation
jswhit2 Feb 25, 2021
e575a85
calculate delz increment so it is negative for netcdf (remove sign flip)
jswhit2 Feb 25, 2021
3a7a671
fix typo
jswhit2 Feb 25, 2021
62b27c7
print out min/max ob time
jswhit2 Feb 25, 2021
9e15cee
update
jswhit2 Feb 25, 2021
9b10c13
update
jswhit2 Feb 25, 2021
fc289fb
fix delz calculations so delz is always <0, incr is a-f, and sign fli…
jswhit2 Mar 2, 2021
d2f09f7
fix missing declaration of krev
jswhit2 Mar 2, 2021
7c9d680
fix sign of delz
jswhit2 Mar 2, 2021
f76ba28
fix delz to be consistent with PR #116
jswhit2 Mar 3, 2021
1c08d68
global_2mDA updates for 2m obs:
ClaraDraper-NOAA Mar 1, 2021
57a74cf
Merge branch 'feature/2mDA_csd' of https://github.com/ClaraDraper-NOA…
ClaraDraper-NOAA Mar 3, 2021
98d7d71
fix integer arithmetic so +/-30 minute windows work (with l4densvar=F)
jswhit2 Mar 11, 2021
e7e0320
Merge remote-tracking branch 'upstream/master'
jswhit2 Mar 11, 2021
ffe1f24
Merge branch 'master' into feature/enkf-64bit
jswhit2 Mar 11, 2021
2525f68
revert previous fix for hourly updating problem
jswhit2 Mar 11, 2021
780b6a4
fix typo
jswhit2 Mar 11, 2021
0f4555e
Merge pull request #1 from ClaraDraper-NOAA/feature/2mDA_csd
jswhit Mar 30, 2021
96f7380
add new parameter mincorrlength_fact
jswhit2 Apr 26, 2021
39b044b
set nobsl_max=-1 if nobstot < nobsl_max
jswhit2 Apr 26, 2021
1c25e4b
bound corrlength between correlength and mincorrlength_fact*corrlengt…
jswhit2 Apr 26, 2021
156d87e
add tapering of humidity increments in stratosphere
jswhit2 Apr 27, 2021
8ea8639
add tapering of humidity increments in strat
jswhit2 Apr 27, 2021
2790e5f
Merge remote-tracking branch 'upstream/master'
jswhit2 Apr 27, 2021
68f6e6f
Merge branch 'master' into feature/enkf-64bit
jswhit2 Apr 27, 2021
86f7929
fix netcdf bug
jswhit2 Apr 27, 2021
efba493
populate ak,bk
jswhit2 Apr 29, 2021
ba010a8
fixes for strat tapering
jswhit2 Apr 30, 2021
86a548a
Merge branch 'NOAA-EMC:master' into master
jswhit May 19, 2021
df33214
Merge branch 'NOAA-EMC:master' into feature/enkf-64bit
jswhit May 19, 2021
9c731e2
Merge remote-tracking branch 'upstream/master'
jswhit2 Jun 24, 2021
f7d0066
Merge branch 'master' into feature/enkf-64bit
jswhit2 Jun 24, 2021
a956556
fix writing of ensemble mean
jswhit2 Jun 25, 2021
11fba4f
Merge remote-tracking branch 'upstream/master'
jswhit2 Jul 15, 2021
f471641
Merge remote-tracking branch 'upstream/master'
jswhit2 Jul 28, 2021
d0e21fb
Merge branch 'master' into feature/enkf-64bit
jswhit2 Jul 28, 2021
56f6b37
Merge branch 'master' into feature/2mDA
jswhit2 Jul 28, 2021
20a7310
Moved read of pressure to be from sfc files, comment out buddy check …
ClaraDraper-NOAA Aug 4, 2021
3d3646f
Merge remote-tracking branch 'upstream/feature/2mDA' into feature/2mD…
ClaraDraper-NOAA Aug 4, 2021
7d84c64
Merge remote-tracking branch 'upstream/master'
jswhit2 Aug 18, 2021
11a039e
Merge branch 'master' into feature/enkf-64bit
jswhit2 Aug 18, 2021
a04266b
Merge pull request #2 from ClaraDraper-NOAA/feature/2mDA_csd
jswhit Aug 18, 2021
3ec7a3f
Merge branch 'feature/enkf-64bit' into feature/2mDA
jswhit2 Aug 18, 2021
e5c4d53
Merge remote-tracking branch 'upstream/master'
jswhit2 Aug 26, 2021
7fff4ac
Merge remote-tracking branch 'upstream/master'
jswhit2 Sep 10, 2021
212e3dd
Merge remote-tracking branch 'upstream/master'
jswhit2 Oct 8, 2021
da004e0
Merge remote-tracking branch 'upstream/master'
jswhit2 Nov 10, 2021
8a6641b
Merge branch 'NOAA-EMC:master' into master
jswhit Nov 10, 2021
a297111
remove unneeded files
jswhit2 Nov 10, 2021
dbc7ad4
Merge remote-tracking branch 'upstream/master'
jswhit2 Nov 30, 2021
e3aad64
Merge remote-tracking branch 'upstream/master'
jswhit2 Dec 16, 2021
344e1b1
Merge remote-tracking branch 'upstream/master'
jswhit2 Jan 6, 2022
b81a0a5
Merge remote-tracking branch 'upstream/master'
jswhit2 Jan 19, 2022
46e72f5
Bugfix for writing out 2mDA increments.
ClaraDraper-NOAA Mar 2, 2022
c8f68f1
Merge pull request #3 from ClaraDraper-NOAA/feature/2mDA
jswhit Mar 2, 2022
5f5a859
Merge remote-tracking branch 'upstream/master'
jswhit2 Mar 2, 2022
d2931d5
Merge branch 'master' of https://github.com/jswhit/GSI
jswhit2 Mar 2, 2022
9ac41fe
Merge branch 'master' into feature/2mDA
jswhit2 Mar 2, 2022
15459d8
Merge remote-tracking branch 'upstream/master'
jswhit2 Apr 13, 2022
0a82587
stage-1 merge with regional 2mDA from GSL
guoqing-noaa Jun 1, 2022
6283523
trying to add save_jacobian for 2mT DA
guoqing-noaa Jul 6, 2022
94706a7
Added endif statement to controlvec that had been inadvertently removed.
ClaraDraper-NOAA Jul 9, 2022
45d3aeb
Added end if statement back to controlvec that had inavertently been …
ClaraDraper-NOAA Jul 9, 2022
51d9b4b
Separated reading in 2m obs from doing sfc update. Changes observer
ClaraDraper-NOAA Jul 13, 2022
d5fae40
Changed setupt output QC marks back to original values.
ClaraDraper-NOAA Jul 13, 2022
2d12089
Merge pull request #4 from guoqing-noaa/merge
jswhit Jul 13, 2022
30cb954
Merge branch 'jswhit:feature/2mDA' into feature/2mDA
ClaraDraper-NOAA Jul 13, 2022
3dd4439
Merge branch 'feature/2mDA' into feature/2mDA_4atmosupdate
ClaraDraper-NOAA Jul 13, 2022
2c6d9e5
Reverted drpx and dpres code for use_2m_obs option, and changes to co…
ClaraDraper-NOAA Jul 14, 2022
0a264f6
Merge remote-tracking branch 'upstream/develop'
jswhit2 Jul 14, 2022
16f9d2c
Midway through generalising the 2m DA case:
ClaraDraper-NOAA Jul 26, 2022
e7e8754
Fixed bug in sfc variable indexing into grdin
ClaraDraper-NOAA Jul 26, 2022
53c3ebb
changed dhx_dx dimension in setupt to cover both profile and single l…
ClaraDraper-NOAA Jul 26, 2022
965ca0f
Combined write routines to single routine for sfc and/or atmos fields.
ClaraDraper-NOAA Aug 12, 2022
299e368
Tidy up of read/write for sfc files.
ClaraDraper-NOAA Aug 12, 2022
7046544
Removed global_2mDA input flag.
ClaraDraper-NOAA Aug 12, 2022
cf68497
Updates ot gsi:
ClaraDraper-NOAA Aug 12, 2022
7cf05a4
Merge pull request #6 from ClaraDraper-NOAA/feature/2mDA_4atmosupdate
jswhit Aug 16, 2022
fafbed4
Added back in application of increment to T2m between outer loops.
ClaraDraper-NOAA Aug 18, 2022
e4e9dbe
minor bug fix.
ClaraDraper-NOAA Aug 18, 2022
6326827
Bugfix in setupt - settings obs are surface level for hofx_2m_file op…
ClaraDraper-NOAA Sep 1, 2022
dad7eed
Merge remote-tracking branch 'upstream/develop'
jswhit2 Sep 23, 2022
4dfd73b
removing unnecessary print statements.
ClaraDraper-NOAA Sep 23, 2022
4002db4
Merge branch 'master' into feature/2mDA
jswhit2 Sep 23, 2022
29cca95
Merge branch 'feature/2mDA' into bugfix2mDA
jswhit Sep 23, 2022
5f08c29
Merge pull request #8 from ClaraDraper-NOAA/bugfix2mDA
jswhit Sep 23, 2022
922a5c4
bug fix on latest merge of EMC develop and 2mDA
guoqing-noaa Oct 4, 2022
95a3dc8
revert changes on src/gsi/netcdfgfs_io.f90
guoqing-noaa Oct 4, 2022
f5e537b
go ahead with the changes on src/gsi/netcdfgfs_io.f90
guoqing-noaa Oct 4, 2022
9d454b9
revert changes on src/gsi/netcdfgfs_io.f90
guoqing-noaa Oct 4, 2022
c7be078
minor fix on src/gsi/setupt.f90
guoqing-noaa Oct 12, 2022
2046b38
more changes
guoqing-noaa Oct 26, 2022
0f00543
Merge pull request #9 from guoqing-noaa/bugfix
jswhit Oct 26, 2022
c2d7cbb
Merge remote-tracking branch 'upstream/develop'
jswhit2 Nov 14, 2022
0fa9c97
Merge remote-tracking branch 'upstream/develop'
jswhit2 Nov 22, 2022
fd4f5a1
Merge remote-tracking branch 'upstream/develop'
jswhit2 Nov 22, 2022
c875be3
minor fix on read_prepbufr.f90
guoqing-noaa Jan 3, 2023
f9fe490
read_prepbufr.f90, hardwire obs err, qob not considered yet
guoqing-noaa Jan 4, 2023
7681e2b
debug setupt.f90 and successfully pinned the bug
guoqing-noaa Jan 4, 2023
5a8e06e
remove debug writes
guoqing-noaa Jan 4, 2023
62767d8
update read_prepbufr.f90 for surface qob
guoqing-noaa Jan 18, 2023
b22d832
Merge remote-tracking branch 'upstream/develop'
jswhit2 Jan 18, 2023
673bc86
Merge branch 'master' into feature/2mDA
jswhit2 Jan 18, 2023
bb5c08c
changes in response to PR review
guoqing-noaa Jan 18, 2023
a268603
Merge pull request #10 from guoqing-noaa/pr2mDA
jswhit Jan 18, 2023
39aba44
Merge branch 'feature/2mDA' of https://github.com/jswhit/GSI into fea…
ClaraDraper-NOAA Mar 9, 2023
697ae98
Tidied up comments, treatment of non-land sfc obs for hofx_sfc_file o…
ClaraDraper-NOAA Mar 9, 2023
abea0fa
Tidy up routine to read in sfc background files.
ClaraDraper-NOAA Mar 10, 2023
c0f167f
bug fix to qm in read_prepbufr.
ClaraDraper-NOAA Mar 12, 2023
dac28ac
Clean up to remove unnecessary diffs from develop.
ClaraDraper-NOAA Mar 20, 2023
c4701a0
clean up to gridio.
ClaraDraper-NOAA Mar 20, 2023
d439812
Removed separate diag file name for sfc, and added input to option to…
ClaraDraper-NOAA Mar 20, 2023
b492175
Merge branch 'develop' into feature/2m_hofx
ClaraDraper-NOAA Mar 21, 2023
adaca8f
Over-ride qob qc marks for obs types 181, 183, and 187 in read_prepbu…
ClaraDraper-NOAA Mar 21, 2023
99cd8b8
Setup for getting q2m from file.
ClaraDraper-NOAA Mar 21, 2023
1623ae2
minor updates.
ClaraDraper-NOAA Mar 22, 2023
db75164
Added horizontal interpolation of q2m to setupq. Fixed icount by in g…
ClaraDraper-NOAA Mar 22, 2023
47cd2c8
Added terrain correction to qob in setupq.
ClaraDraper-NOAA Mar 23, 2023
a8f37ce
Removed all q error inflation from qobs in setupq.
ClaraDraper-NOAA Mar 23, 2023
9bc595f
Added comments to gsi code.
ClaraDraper-NOAA Mar 23, 2023
a4b05b8
Added inflation of q ob error when vertically interpolating the obs.
ClaraDraper-NOAA Mar 23, 2023
47d7c5a
small bugfix
ClaraDraper-NOAA Mar 23, 2023
2767046
Fixed GCC linux build bug (inconsistent string length in vars2d_suppo…
ClaraDraper-NOAA Mar 24, 2023
ab578df
Merge branch 'develop' into feature/2m_hofx
ClaraDraper-NOAA Mar 24, 2023
cd1b50b
Merge branch 'develop' into feature/2m_hofx
ClaraDraper-NOAA Mar 28, 2023
161120d
Merge branch 'develop' into feature/2m_hofx
ClaraDraper-NOAA Apr 24, 2023
3de5aef
Response to Guoqing's review:
ClaraDraper-NOAA Apr 24, 2023
0beaed6
removed option to not scale qobs by qsat, following Guoqing's questions.
ClaraDraper-NOAA Apr 28, 2023
f192cfd
Minor bugfix.
ClaraDraper-NOAA Apr 28, 2023
cb19037
Merge branch 'develop' into feature/2m_hofx
ClaraDraper-NOAA May 11, 2023
ae6ab26
removing accidental change to innovstats.f90
ClaraDraper-NOAA May 11, 2023
accfe62
Fixed incorrect error messagse in general_read_gfsatm.f90
ClaraDraper-NOAA May 18, 2023
21d17f2
Added sfc read to allhydro routine
ClaraDraper-NOAA May 18, 2023
82f3638
fixed incorrect comment in setupq.
ClaraDraper-NOAA May 24, 2023
6102bad
Merge branch 'NOAA-EMC:develop' into feature/2m_hofx
ClaraDraper-NOAA Jun 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/enkf/controlvec.f90
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ subroutine init_controlvec()
cvars3d(nc3d) = trim(adjustl(var))
clevels(nc3d) = ilev + clevels(nc3d-1)
else
if (nproc .eq. 0) print *,'Error: only ', nlevs, ' and ', nlevs+1,' number of levels is supported in current version, got ',ilev
if (nproc .eq. 0) print *,'Error controlvec: only ', nlevs, ' and ', nlevs+1,' number of levels is supported in current version, got ',ilev
call stop2(503)
endif
enddo
Expand Down Expand Up @@ -212,7 +212,10 @@ subroutine read_control()
! read in whole control vector on i/o procs - keep in memory
! (needed in write_ensemble)
allocate(grdin(npts,ncdim,nbackgrounds,nanals_per_iotask))
allocate(qsat(npts,nlevs,nbackgrounds,nanals_per_iotask))
! if only updating the sfc fields, qsat will not be calculated in readgriddata
! only allocate if needed.
q_ind = getindex(cvars3d, 'q')
if (q_ind > 0) allocate(qsat(npts,nlevs,nbackgrounds,nanals_per_iotask))
if (paranc) then
if (nproc == 0) t1 = mpi_wtime()
call readgriddata_pnc(cvars3d,cvars2d,nc3d,nc2d,clevels,ncdim,nbackgrounds, &
Expand All @@ -225,7 +228,8 @@ subroutine read_control()
fgfileprefixes,fgsfcfileprefixes,reducedgrid,grdin,qsat)
end if
!print *,'min/max qsat',nanal,'=',minval(qsat),maxval(qsat)
if (use_qsatensmean) then
q_ind = getindex(cvars3d, 'q')
if (use_qsatensmean .and. q_ind>0 ) then
allocate(qsatmean(npts,nlevs,nbackgrounds))
allocate(qsat_tmp(npts))
! compute ensemble mean qsat
Expand Down Expand Up @@ -257,7 +261,6 @@ subroutine read_control()
! print *,'min/max qsatmean proc',nproc,'=',&
! minval(qsatmean(:,:,nbackgrounds/2+1)),maxval(qsatmean(:,:,nbackgrounds/2+1))
!endif
q_ind = getindex(cvars3d, 'q')
if (pseudo_rh .and. q_ind > 0) then
if (use_qsatensmean) then
do ne=1,nanals_per_iotask
Expand Down
2 changes: 1 addition & 1 deletion src/enkf/gridinfo_gfs.f90
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ module gridinfo
! supported variable names in anavinfo
character(len=max_varname_length),public, dimension(13) :: vars3d_supported = (/'u ', 'v ', 'tv ', 'q ', 'oz ', 'cw ', 'tsen', 'prse', &
'ql ', 'qi ', 'qr ', 'qs ', 'qg '/)
character(len=max_varname_length),public, dimension(3) :: vars2d_supported = (/'ps ', 'pst', 'sst' /)
character(len=max_varname_length),public, dimension(13) :: vars2d_supported = (/'ps ', 'pst', 'sst', 't2m', 'q2m', 'st1', 'st2', 'st3', 'st4', 'sl1', 'sl2', 'sl3', 'sl4' /)
! supported variable names in anavinfo
contains

Expand Down
Loading