Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined 'soil temperature' found in RRFS #677

Closed
xyzemc opened this issue Jan 8, 2024 · 1 comment · Fixed by #683
Closed

Undefined 'soil temperature' found in RRFS #677

xyzemc opened this issue Jan 8, 2024 · 1 comment · Fixed by #683
Assignees
@xyzemc

Comments

@xyzemc
Copy link
Contributor

xyzemc commented Jan 8, 2024 •
edited
Loading

We have found that the soil_temp is not defined by reading from fv3_sfcdata in gsi_fv3ncdf2d_read as

         else if( trim(name)=='stc'.or.trim(name)=='STC' ) then
             k=k_stc

While there is no variable named as 'stc' or 'STC' in fv3 restart file. This means there is no soil_temp be defined. So the value of soil_temp could be zero or some random values.
We need to fix this to ensure the correct soil temperature be read in from the RRFS restart file.
@xyzemc
Copy link
Contributor Author

xyzemc commented Jan 8, 2024

@hu5970 has confirmed that the soil temperature is named as 'tslb' in RRFS warm-start restart surface file. Will use that to correct the gsi_fv3ncdf2d_read code in GSI.

@xyzemc xyzemc mentioned this issue Jan 16, 2024
Merged
ShunLiu-NOAA pushed a commit that referenced this issue Feb 9, 2024
@xyzemc
Fix soil temperature/mositure read from RRFS warm-start r… (#683)
bae0342 
**DUE DATE for merger of this PR into `develop` is 2/27/2024 (six weeks
after PR creation).**

**Description**

- Undefined soil_temp and soil_moist for regional because they are not
correctly read in from the RRFS' warm-sart restart file as described in
the issue#677.
- Undefined or zero value of soil temp and moist will affect the
calculation of surface emissivity. Surface emissivity is a factor to
calculate the microwave surface channel radiance.

Resolves #677

**Fix**
In gsi_rfv3io_mod.f90, replace 'STC' with 'tslb', replace 'SMC' as
'smois

**How has this need tested?**

- This has been tested on Hera. The values of soil_temp and
soil_moisture have been verified are correct now from the RRFS restart
file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xyzemc xyzemc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix soil temperature/mositure read from RRFS warm-start r… xyzemc/GSI
1 participant
@xyzemc