Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A quick enhancement for clipping negative Q in the analysis of EnKF for fv3-lam #566

Closed
TingLei-NOAA opened this issue May 4, 2023 · 1 comment · Fixed by #568
Closed
Assignees

Comments

@TingLei-NOAA
Copy link
Contributor

In the current FV3-LAM EnKF, negative values in the hydrometers wold be replaced with the minimum positive values available in the running of this program. But this clipping is not applied to the moisture (sphum ). The negative values would cause issues for the following modeling/forecast if the model wouldn't use clipping on its' own, that is the case found by @JiliDong-NOAA
Hence, a quick adding of such clipping for sphum (q) in the fv3-lam EnKF is to be done.

TingLei-daprediction added a commit to TingLei-daprediction/GSI that referenced this issue May 4, 2023
…oisture values in the analysis of EnKF for FV3-LAM
TingLei-daprediction added a commit to TingLei-daprediction/GSI that referenced this issue May 4, 2023
…oisture values in the analysis of EnKF for FV3-LAM
@ShunLiu-NOAA
Copy link
Contributor

David and Chunhua,

Could you please review Ting's changes? We want to implement the change in rrfs v0.5.
Thank you.

TingLei-daprediction added a commit to TingLei-daprediction/GSI that referenced this issue May 4, 2023
…oisture values in the analysis of EnKF for FV3-LAM
TingLei-daprediction added a commit to TingLei-daprediction/GSI that referenced this issue May 5, 2023
…oisture values in the analysis of EnKF for FV3-LAM

also remove the condition of l_use_enkf_directZDA=.true. for clipping of negative values for hydrometeors when cliptracers=.true.
ShunLiu-NOAA pushed a commit that referenced this issue Jun 27, 2023
Resubmit PR for cleaning the unneeded item in the previous PR 
In correspondence to the EMC GSI Issue#566, this PR contains a quick
adding of the clipping of negative values of sphum (q) in the analysis
of FV3-LAM EnKF.
This part of codes are not tested in the current GSI regression tests,
which, hence, are not run.
The current codes are verified using local FV3-LAM case. It is found the
differences from this changes exist for sphum ( maximum values about
0.003 (units) and 0.3 K for T (sensible T). The latter is because the
sphum would be used when the analysis TV is converted to T. All
differences are on spontaneous points and values are reasonable as
expected.
Hence, the code is regarded as verified.

Fixes #566

**DUE DATE for this PR is 6/15/2023.** If this PR is not merged into
`develop` by this date, the PR will be closed and returned to the
developer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants