Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hydrostatic_delz to delz #1284

Merged
merged 9 commits into from
Sep 25, 2024
Merged

Conversation

DavidNew-NOAA
Copy link
Collaborator

@DavidNew-NOAA DavidNew-NOAA commented Sep 17, 2024

This PR is a companion to FV3-JEDI PR #1263 and JCB-GDAS PR #27. It changes hydrostatic_delz to delz in the FV3 increment fields metadata override file, along with the test input and reference file for one CTest. See the above referenced FV3-JEDI PR for motivation and other details.

The gdasapp_fv3jedi_fv3inc CTest passes with these changes.

@DavidNew-NOAA
Copy link
Collaborator Author

I'm rolling this PR into another one, so will close it.

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but changes look good.

@RussTreadon-NOAA
Copy link
Contributor

@danholdaway , if you have a chance would you take a look at this PR from @DavidNew-NOAA. We need the changes in this PR if we update the fv3-jedi hash.

@RussTreadon-NOAA
Copy link
Contributor

RussTreadon-NOAA commented Sep 23, 2024

Testing of these changes along reported in jcb-gdas PR #27. Combination of these two PRs works!

@RussTreadon-NOAA
Copy link
Contributor

@DavidNew-NOAA, once jcb-gdas PR #27 is merged into jcb-gdas develop, we need to update the parm/jcb-gdas hash in this PR.

@RussTreadon-NOAA
Copy link
Contributor

jcb-gdas PR #27 merged. Done at 272d6d7.

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jcb-gdas at 272d6d7 replaces hydrostatic_delz with delz. This is correct.

Approve.

@RussTreadon-NOAA
Copy link
Contributor

@DavidNew-NOAA , the jcb-gdas hash has been updated in feature/hydrostatic-delz. Given your confirmation that everything looks correct, we can merge into develop.

@DavidNew-NOAA
Copy link
Collaborator Author

@RussTreadon-NOAA Looks good. Let's merge it

@RussTreadon-NOAA RussTreadon-NOAA merged commit c797d33 into develop Sep 25, 2024
5 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/hydrostatic-delz branch September 25, 2024 12:38
@danholdaway
Copy link
Contributor

Just catching up, sick kid. Is it safe to update the hash of just fv3-jedi and not other JEDI repos?

@DavidNew-NOAA
Copy link
Collaborator Author

@danholdaway I tested it in an experiment on Hera GW without a problem, though only one cycle.

@DavidNew-NOAA
Copy link
Collaborator Author

@danholdaway Also, the jjob tests passed for @RussTreadon-NOAA NOAA-EMC/jcb-gdas#27 (comment)

jiaruidong2017 pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants