Changes nc4 file suffix to nc on IODA observation files

[AndrewEichmann-NOAA]

Tested with SOCA ctest on Hera

Resolves #1215

[guillaumevernieres]

it's a bit more involved than this @AndrewEichmann-NOAA , prep and post will probably be affected and probably the archiving task in the g-w.

[AndrewEichmann-NOAA]

it's a bit more involved than this @AndrewEichmann-NOAA , prep and post will probably be affected and probably the archiving task in the g-w.

Is there a test (a manual one, a condition to be met) that would satisfy these issues?

[guillaumevernieres]

it's a bit more involved than this @AndrewEichmann-NOAA , prep and post will probably be affected and probably the archiving task in the g-w.

Is there a test (a manual one, a condition to be met) that would satisfy these issues?

beyond the ctests that we already have?

[guillaumevernieres]

my grepping says you missed "nc4" in exgdas...post.py

[AndrewEichmann-NOAA]

The ctests work without the change in post, so maybe there should be something else considered, assuming this goes forward

[guillaumevernieres]

The ctests work without the change in post, so maybe there should be something else considered, assuming this goes forward

that's a problem for sure, our ctest only check if stuff ran without failure, it's useful but a bit primitive!