Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ocean/ice B diag #1050

Merged
merged 30 commits into from
Apr 18, 2024
Merged

New ocean/ice B diag #1050

merged 30 commits into from
Apr 18, 2024

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Apr 16, 2024

What was done

  • Variance partitioning of ice and ocean backgrounds
  • Switch to using the StdDev saber block with the above fields as a proxy of the background error
  • Changed the obs filtering
  • Removed the hybrid B, will plug it back in later
  • Use Travis' script to extract the vertical decorrelation scales from the bkg, using the mld.
  • Use of jinja for the new yamls
  • setting NMEM_ENS to something larger that 3 will trigger the hybrid envar and use static or real members, depending on the status or DO_HYBVAR

The results are reasonable but some of the parameters of the variance partitioning still need to be optimized further

apchoiCMD
apchoiCMD previously approved these changes Apr 16, 2024
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion labels Apr 17, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 17, 2024
@emcbot
Copy link

emcbot commented Apr 17, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Wed Apr 17 13:30:59 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Apr 17 14:23:32 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Apr 17 14:45:07 CDT 2024
Tests: 94% tests passed, 3 tests failed out of 53
	1776 - test_gdasapp_atm_jjob_var_run (Failed)
	1777 - test_gdasapp_atm_jjob_var_inc (Failed)
	1778 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1050/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 17, 2024
@emcbot
Copy link

emcbot commented Apr 17, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Apr 17 18:30:37 UTC 2024 on hfe08
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Apr 17 19:18:36 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Apr 17 19:52:59 UTC 2024
Tests: 94% tests passed, 3 tests failed out of 53
	1775 - test_gdasapp_atm_jjob_var_run (Failed)
	1776 - test_gdasapp_atm_jjob_var_inc (Failed)
	1777 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1050/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Apr 17, 2024
@CoryMartin-NOAA CoryMartin-NOAA merged commit 5b464c6 into develop Apr 18, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/diagb branch April 18, 2024 13:06
danholdaway added a commit that referenced this pull request Apr 23, 2024
* upstream/develop:
  More marine DA bufixes  (#1069)
  Add basin flags to the ocean obs (#1067)
  Revert "Prepare observations for snow DA updates to the ensemble members" (#1066)
  Fix aero_diagb template (#1064)
  Refactoring prepocnobs task (#1049)
  Ensemble diagnostics not triggered properly (#1060)
  New ocean/ice B diag (#1050)
  Remove R2D2 and SOLO from the GitHub Actions workflow CI (#1058)
  Variance Partition estimates of Stddev for aerosols (#1037)
  Removing ctests of an obsolete bufr_converter in SOCA (#1056)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parametric diag of B Test the marine DA with DOHYBVAR=YES AND NO Localization for EnVar is too slow
5 participants