Always remove duplicates from NetCDF_LIBRARIES list, not just for shared libraries

[climbfuji]

Description

Alternative approach to solve the problem described in #66, but which had to be reverted because it broke the builds for others.

I don't know what the reason for not removing duplicates for static libraries is, but maybe @DJDavies2 and @drnimbusrain can give this a try?

[DJDavies2]

I tested this and seems to work for me in the sense that there are no duplicates any more.

[climbfuji]

@drnimbusrain Would you be able to test this PR? Thanks very much in advance!

[climbfuji]

I tested this and seems to work for me in the sense that there are no duplicates any more.

Thanks, @DJDavies2 !

[climbfuji]

@drnimbusrain I would like to proceed with this PR. Do you think you can take a minute to test it as well? It works for our UK Met Office colleagues. Thanks!

[aerorahul]

makes sense.

[drnimbusrain]

Sorry for the late reply Dom, I will test this afternoon. Thank you

…

On Wed, Sep 6, 2023, 2:46 PM Dom Heinzeller ***@***.***> wrote: @drnimbusrain <https://github.com/drnimbusrain> I would like to proceed with this PR. Do you think you can take a minute to test it as well? It works for our UK Met Office colleagues. Thanks! — Reply to this email directly, view it on GitHub <#68 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLFYNRBPXSGD7JPEWCZ7F3XZDAJRANCNFSM6AAAAAA33TKUYQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[drnimbusrain]

@climbfuji I have tested your branch and it works successfully on NOAA's RDHPCS/Hera and WCOSS2 machines, e.g.,

• Setting build type to 'Release'.
  -- Found NetCDF: /scratch1/NCEPDEV/nems/role.epic/hpc-stack/libs/intel-2022.1.2/intel-2022.1.2/impi-2022.1.2/netcdf/4.7.4/include (found version "4.7.4") found components: C Fortran

Thank you!!

[climbfuji]

Yay, thanks for testing @drnimbusrain.

@aerorahul please merge whenever you want. Thanks very much!