Add Aircraft Examples and Update Docs #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rschwant
commented
Oct 3, 2024
rschwant
commented
- Add aircraft examples for AEROMMA and UFS-AQM evaluation
- Update docs to include aircraft pairing example
- Update docs to include aircraft plotting example. For this I also had to update the util function to read in the data through pooch. So Colin I'm adding you here to check this, but this seems to work fine.
- Update docs miscellaneous items: Add model table with more description than current list, add model variables to adding datasets in develop section, update developers guide to remove extra branches that no longer exist.
rschwant
requested review from
zmoon,
quaz115,
colin-harkins and
mbruckner-work
quaz115
approved these changes
Oct 3, 2024
zmoon
reviewed
Oct 4, 2024
...t/aeromma_ufsaqm/plot_grp1.timeseries.CO_LGR.2023-06-27_00.2023-06-28_23.all.Los Angeles.png
Outdated
Show resolved
Hide resolved
zmoon
reviewed
Oct 4, 2024
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
zmoon
reviewed
Oct 4, 2024
Comment on lines
+47
to
+48
| | All gases are in ppb and | ||
| | all aerosols are in µg/m3. |
There was a problem hiding this comment.
Not sure if this is a "requirement", as you can get around magnitude differences, e.g., using MM config. But certainly it's usually easier if they are in these units.
There was a problem hiding this comment.
I want to list it as a requirement, so that there is consistency in the tool. But of course, if people prefer not to do this, there will not be an error and you can fix it in the unit conversion step later.
There was a problem hiding this comment.
I would also prefer "ppbv" if you agree.
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.