Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: more metadata for get-aqs #277

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

zmoon
Copy link
Collaborator

@zmoon zmoon commented Sep 24, 2024

This adds a few more site metadata fields, including CBSA name, city name, state abbreviation, and EPA region.

cc: @btang1

@zmoon
Copy link
Collaborator Author

zmoon commented Sep 24, 2024

@btang1 sites where city name is "Not in a city" might be a good rural indicator. Or where CBSA name is "" (empty string).

melodies_monet/_cli.py Outdated Show resolved Hide resolved
@zmoon
Copy link
Collaborator Author

zmoon commented Oct 1, 2024

Current CI failures related to NCEI websites being down.

@zmoon
Copy link
Collaborator Author

zmoon commented Oct 7, 2024

@btang1 did you end up trying this out?

@btang1
Copy link
Contributor

btang1 commented Oct 7, 2024

@btang1 did you end up trying this out?

I will try it later today or tomorrow @zmoon

@btang1
Copy link
Contributor

btang1 commented Oct 9, 2024

@btang1 did you end up trying this out?

I will try it later today or tomorrow @zmoon

@zmoon I tried "melodies-monet get-aqs -p SO2 -s 2023-08-01 -e 2023-08-07" and it does not show new variables in. do I need to swith to some branch to use this function?

@zmoon
Copy link
Collaborator Author

zmoon commented Oct 9, 2024

Yeah this is on my fork's branch cli-aqs-meta.

@btang1
Copy link
Contributor

btang1 commented Oct 9, 2024

Yeah this is on my fork's branch cli-aqs-meta.

Is it in Monet? or Monet io?

@btang1
Copy link
Contributor

btang1 commented Oct 9, 2024

Yeah this is on my fork's branch cli-aqs-meta.

Is it in Monet? or Monet io?

ok. I found it! it is in your melodies-monet. let me test it quick!

@btang1
Copy link
Contributor

btang1 commented Oct 9, 2024

Yeah this is on my fork's branch cli-aqs-meta.

Hi Zach, I tested and it works!!!
Screenshot 2024-10-09 at 1 42 40 PM

I can find new variables you mention in so2 data from AQS.

@btang1
Copy link
Contributor

btang1 commented Oct 9, 2024

@zmoon

@zmoon zmoon requested a review from rschwant October 23, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants