processing TROPOMI L2 NO2 data and plot #225
Conversation
| # Copyright (C) 2022 National Center for Atmospheric Research and National Oceanic and Atmospheric Administration | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # calculate WRF-Chem NO2 trop. columns, for further pair with satellite swath data |
There was a problem hiding this comment.
Is this only for WRF comparisons right now and you plan to generalize to more models later? Or should we call this python script cal_wrf_no2col.py?
There was a problem hiding this comment.
This is for WRF right now. I'm not sure if this can be applied to other models. It should work but with several modifications such as variable names, etc. I think it does make sense to change it to cal_wrf_no2col.py.
|
Hi Meng, |
|
@dwfncar : David I'm not sure what issues might be remaining in Meng's pull request. She harmonized the driver. Could you possibly take a look? Thanks! |
|
P.S. @mlirenzhenmayi : Meng it looks like these might be the issue: But thinking about these further... should this code be inside the: satellite_utilities.py file? |
|
@mlirenzhenmayi - could you pull another two updates two your branch? There's one for driver.py and one for satplots.py. |
|
Looks like AERONET web server is currently being updated, causing a CI failure. |
|
Hmmm, am wondering why we need the AERONET data for the TROPOMI satellite code? |
It's a test of the Note that the linter check is still failing since |
|
Thanks Zach! I see maybe you added those license lines now to those files? Or is there something else? |
|
@zmoon Is there something else we need to add to the license headers? |
|
@rrbuchholz sorry for missing your previous comment. The check actually looks for a blank comment line after the two license lines, i.e. the first three lines should be like this: MELODIES-MONET/ci/check-for-license-header.py Lines 10 to 12 in ececa25 |
adding space after license
adding space after license
|
@zmoon OK - awesome. I added those spaces and it seems the AQS check is failing again? But lint is passing. |
|
@rrbuchholz I re-ran that one and it passed. This newer kind of AQS download failure is intermittent. |
melodies_monet/driver.py
Outdated
| @@ -974,6 +974,37 @@ def pair_data(self, time_interval=None): | |||
| p.obj = paired_data | |||
| label = '{}_{}'.format(p.obs,p.model) | |||
| self.paired[label] = p | |||
|
|
|||
| if obs.label == 'tropomi_l2_no2': | |||
There was a problem hiding this comment.
Should this be called on the obs.sat_type instead? I think we decided to keep label as a fairly subjective thing (say there are several version of tropomi retrievals, then you could use the label to differentiate them).
There was a problem hiding this comment.
Yes, that should now be obs.sat_type and not obs.label. I think that change may have been made during the process of the big develop_satellite merge.
There was a problem hiding this comment.
OK, great - I changed that in the driver file for tropomi.
changing obs.label flag to obs.sat_type in the driver for tropomi processing
Processing TROPOMI L2 NO2 data and plotting