Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address other mpl cmap deprecation cases #161

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Address other mpl cmap deprecation cases #161

merged 2 commits into from
Feb 28, 2023

Conversation

zmoon
Copy link
Collaborator

@zmoon zmoon commented Feb 23, 2023

We missed some in #154

@zmoon zmoon changed the base branch from main to develop February 23, 2023 22:31
@zmoon zmoon changed the title Address other cmap deprecation cases Address other mpl cmap deprecation cases Feb 23, 2023
@zmoon zmoon marked this pull request as ready for review February 28, 2023 16:46
jianheACM
jianheACM approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@jianheACM jianheACM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like matplotlib.cm.get_cmap is deprecated since version 3.7...
Thank you @zmoon for updating this.

@zmoon
Copy link
Collaborator Author

zmoon commented Feb 28, 2023

Thanks @jianheACM

@zmoon zmoon merged commit 5e9e6f6 into NOAA-CSL:develop Feb 28, 2023
@zmoon zmoon deleted the cmap-depr branch February 28, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianheACM jianheACM jianheACM approved these changes

@rschwant rschwant Awaiting requested review from rschwant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmoon @jianheACM