Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pineappl 0.8.2 #297

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Update pineappl 0.8.2 #297

merged 5 commits into from
Jul 24, 2024

Conversation

giacomomagni
Copy link
Collaborator

Update pineappl to version 0.8.2

@giacomomagni giacomomagni added the dependencies Pull requests that update a dependency file label Jul 24, 2024
@giacomomagni
Copy link
Collaborator Author

do we want to change the other occurrences of convolute in convolve before merging ?

@Radonirinaunimi
Copy link
Member

do we want to change the other occurrences of convolute in convolve before merging ?

I'd say no. We should just change the instances that are affected by pineappl. The pineappl renaming was already too much 🙈

@felixhekhorn
Copy link
Contributor

do we want to change the other occurrences of convolute in convolve before merging ?

I'd say yes 😇 because the verb is just wrong (well non of us is a native speaker ...) - so you can have the decisive vote @giacomomagni if you wish

@giacomomagni
Copy link
Collaborator Author

Yes the math operation is convolve so better fix it.

@Radonirinaunimi
Copy link
Member

Sure, but I don't think we should get into the habits of breaking APIs just for that sake. If we do so I am pretty sure that there will be many things that we could break. Here it is completely harmless because these things are not exposed, but still...

@giacomomagni
Copy link
Collaborator Author

I totally agree, but here we are only changing internal functions and docs, so it's actually a fix.

@giacomomagni
Copy link
Collaborator Author

shall I merge?

@felixhekhorn
Copy link
Contributor

Sure, but I don't think we should get into the habits of breaking APIs just for that sake. If we do so I am pretty sure that there will be many things that we could break. Here it is completely harmless because these things are not exposed, but still...

on general grounds I agree - however, on eko we are facing the opposite: there are PRs which implement new good features, but are breaking and thus get delayed forever

@giacomomagni giacomomagni merged commit cf9b135 into master Jul 24, 2024
5 checks passed
@giacomomagni giacomomagni deleted the update_pineappl branch July 24, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants