Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Windows checks #223

Closed
fdiblen opened this issue Apr 22, 2021 · 5 comments
Closed

Fix failing Windows checks #223

fdiblen opened this issue Apr 22, 2021 · 5 comments
Assignees
Labels
generated-package Related to the generated package, i.e. after running cookiecutter
Milestone

Comments

@fdiblen
Copy link
Member

fdiblen commented Apr 22, 2021

GitHub actions fail on Windows. We should fix it.
Related to #140

@fdiblen fdiblen added the generated-package Related to the generated package, i.e. after running cookiecutter label Apr 22, 2021
@fdiblen fdiblen added this to the 0.4.0 milestone Apr 22, 2021
@sverhoeven sverhoeven self-assigned this Apr 28, 2021
@fdiblen fdiblen modified the milestones: Future, 0.4.0 Apr 28, 2021
@sverhoeven sverhoeven removed their assignment Apr 28, 2021
@sverhoeven
Copy link
Member

Spend a lot of time trying to fixit, but gave up for now
Windows has been disabled in #241 . Failed attempts are #233 and #229

@jspaaks
Copy link

jspaaks commented Apr 28, 2021

Not sure if this is caused by how we test the template or an different reason. If it is the former, I'm wondering if some of those difficulties go away if we don't try to run the template level's pytest to check the generated package?

For example, what if we have two virtual environments, one for the template, the other for the generated package? We could make 2 jobs out of it in one workflow.

@sverhoeven
Copy link
Member

Creating a env on Windows is kaput just having following in GHA workflow:

    - name: venv
      run: python3 -m venv env

Fails with

Run python3 -m venv env
  python3 -m venv env
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    pythonLocation: C:\hostedtoolcache\windows\Python\3.9.4\x64
Error: [WinError 2] The system cannot find the file specified
Error: Process completed with exit code 1.

@sverhoeven
Copy link
Member

Not sure if this is caused by how we test the template or an different reason. If it is the former, I'm wondering if some of those difficulties go away if we don't try to run the template level's pytest to check the generated package?

For example, what if we have two virtual environments, one for the template, the other for the generated package? We could make 2 jobs out of it in one workflow.

In #266 I am, only for Windows CI using the Python version created by actions/setup-python step instead of creating a new virtualenv.

@sverhoeven
Copy link
Member

In #266 Windows test where fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generated-package Related to the generated package, i.e. after running cookiecutter
Projects
None yet
Development

No branches or pull requests

3 participants