Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grid_advanced mode merges grids too aggressively #68

Closed
sigmafelix opened this issue Apr 9, 2024 · 3 comments
Closed

grid_advanced mode merges grids too aggressively #68

sigmafelix opened this issue Apr 9, 2024 · 3 comments
Assignees
@sigmafelix

Comments

@sigmafelix
Copy link
Collaborator

  • mode = "grid_advanced" utilizes minimum spanning tree to merge adjacent grids with intersecting grids less than a threshold.
  • In a highly clustered point sets, this approach results in broad outskirts and a few internal unmerged grids. Points in the outskirt could exceed the number of intersecting points with any grids, which is not intended.
  • Simple go-around is that the merged grids are split by a few horizontal/vertical line
    • Could we design this in a sophisticated way while keeping a decent performance?
@sigmafelix sigmafelix self-assigned this Apr 9, 2024
@sigmafelix sigmafelix mentioned this issue Apr 23, 2024
Merged
@sigmafelix
Copy link
Collaborator Author

Resolved by #70.

@sigmafelix sigmafelix reopened this May 1, 2024
@sigmafelix
Copy link
Collaborator Author

The revision does not work consistently. I will work on this issue again soon.

@sigmafelix
Copy link
Collaborator Author

Resolved by #77

Future roadmap is -- allowing to merge nonadjacent grids getting points below the threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sigmafelix sigmafelix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sigmafelix