Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement grass allometric equations and update default allometric parameters for grass PFT #1206

Merged
merged 15 commits into from
Aug 14, 2024

Merge pull request #1 from rgknox/xlg-grass-allometry-rgk

8fe0407
Select commit
Loading
Failed to load commit list.
Merged

Implement grass allometric equations and update default allometric parameters for grass PFT #1206

Merge pull request #1 from rgknox/xlg-grass-allometry-rgk
8fe0407
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-08-14 01:46:48 ago

0 / 3 tasks completed

3 tasks still to be completed

Details

Required Tasks

Task Status
[ x ] The in-code documentation has been updated with descriptive comments Incomplete
The documentation has been assessed to determine if updates are necessary Incomplete
FATES PASS/FAIL regression tests were run Incomplete
Evaluation of test results for answer changes was performed and results provided Incomplete
Technical Note update: Incomplete
User's Guide update: Incomplete
Many of these modes (especially for crown area and leaf/AG biomass) really could be simplified into 1 generic allometric mode. This may make the code a bit simpler overall. Incomplete
All the derivatives are fine, but in most cases, it could be rewritten in terms of the biomass itself, which saves come floating point operations. I've done this for a few allometric modes. I don't think it's high priority because it's not something computed multiple times a day, but it could save a few milliseconds ;). Incomplete