Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtc/hwrf-physics: merge HWRF saSAS with GFS version, update to a more recent version of ufs-weather-model from EMC develop #39

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 10, 2020

This PR contains

Associated PRs:
NCAR/ccpp-physics#433
NCAR/fv3atm#41
#39

For regression testing information, see below.

…physics (ufs-community#91)

* Update .gitmodules and submodule pointer for fv3atm for code review and testing

* Regression test logs for hera.intel using rt.sh

* Regression test logs for wcoss_dell_p3 using NEMSCompsetRun

* Update submodule pointer for FV3 after renaming S2S suite suite_FV3_GFS_2017_coupled_satmedmf.xml to suite_FV3_GFS_2017_satmedmf_coupled.xml

* Regression test logs for wcoss_dell_p3 using rt.sh; regression test logs for wcoss_cray using rt.sh and NEMSCompsetRun

* Regression test logs for hera.intel using NEMSCompsetRun

* Revert change to .gitmodules and update submodule pointer for fv3atm
@climbfuji climbfuji force-pushed the merge_hwrf-sasas_into_dtc_hwrf-physics branch from 60b5f8c to 997147c Compare April 10, 2020 19:34
…nml.IN; this was done in parm/ccpp_input_nest02.nml.IN, but forgotten in parm/input_nest02.nml.IN
@climbfuji climbfuji force-pushed the merge_hwrf-sasas_into_dtc_hwrf-physics branch from 5e2275c to dfee9ad Compare April 10, 2020 22:16
@climbfuji
Copy link
Collaborator Author

climbfuji commented Apr 10, 2020

Regression testing on hera.intel:

First, run against existing baseline. The following tests fail (all expected):

fv3_stretched_nest (PROD)
fv3_stretched_nest_quilt (PROD)
fv3_regional_c768 (PROD)
fv3_ccpp_gfdlmp_hwrfsas (REPRO)
fv3_ccpp_gfdlmp_hwrfsas (PROD)
fv3_ccpp_stretched_nest (PROD)
fv3_ccpp_regional_c768 (PROD)

Out of those, all tests that contain stretched_nest and regional_c768 fail in PROD mode, because the blocksize in input.nml is changed as part of this commit. This is to avoid non-uniform block sizes, which creates remainder/peel loops when the code is vectorized and often leads to b4b differences with the Intel compiler when the AVX2 SIMD instructions are used (i.e. in PROD mode).

The remaining two tests fv3_ccpp_gfdlmp_hwrfsas in REPRO and PROD mode are new and thus have no baseline to compare against. A manual inspection shows that they run to completion.

rt_hera_intel_against_20200317_baseline.log
rt_hera_intel_against_20200317_baseline_fail_test.log

Second, create a new baseline for these failing tests only. All successful. Sync old/existing baseline /scratch1/BMC/gmtb/ufs-weather-model/RT/NEMSfv3gfs/hwrf-physics-20200317/ to new baseline /scratch1/BMC/gmtb/ufs-weather-model/RT/NEMSfv3gfs/hwrf-physics-20200410/, then sync the newly created baseline results for these tests into it.

rt_create_new_baseline.log

Third, run full set of regression tests against this new baseline. Two tests failed due to super annoying, reoccurring filesystem issues on hera in the first round:

fv3_ccpp_thompson
fv3_ccpp_wrtGauss_nemsio_c768

rt_hera_intel_against_20200410_baseline.log
rt_hera_intel_against_20200410_baseline_fail_test.log

Rerunning those tests only: all pass.

rt_hera_intel_against_20200410_baseline_rerun.log

@climbfuji
Copy link
Collaborator Author

These PRs are ready to merge.

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@climbfuji climbfuji merged commit 06b4aa3 into NCAR:dtc/hwrf-physics Apr 13, 2020
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Sep 24, 2020
Update submodule pointer for fv3atm / ccpp-physics (changes for flexible number of soil levels)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants