Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtc/develop: merge emc/develop 2020/03/11 (after Moorthi's commit, before dycore OMP bugfix) #26

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 12, 2020

See original PR ufs-community#72.

Associated PRs:
NCAR/ccpp-physics#406
NCAR/fv3atm#29
#26

For regression testing info, see below.

junwang-noaa and others added 4 commits March 6, 2020 13:20
* add 2 way atm-wav test

* update FV3 with gcycle change reverted

* update RTPWD and change the coupling frequency

* update RT baseline directory

* Regression test log files on WCOSS Dell

* Regression test log files on WCOSS Cray

* Regression test log files on Hera

* Update FV3 submodule

Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
…testing, update CCPP regression tests from IPD, update tests/rt_ipd_prod_only.conf
@climbfuji
Copy link
Collaborator Author

Regression testing IPD PROD against official EMC baseline on hera.intel: all tests pass

rt_ipd_prod_only.log
RegressionTests_hera.intel.log
Compile_hera.intel.log

@climbfuji
Copy link
Collaborator Author

Regression testing for IPD and CCPP on hera.intel:

(1) Create new DTC baseline for IPD PROD, IPD REPRO, CCPP PROD: all tests pass

Compile_hera.intel.log
RegressionTests_hera.intel.log
rt_full_create_ecflow_after-moorthi-before-dycore-pr7.log

(2) Verify against new DTC baseline (after rsync to final destination) for IPD PROD, IPD REPRO, CCPP REPRO, CCPP PROD: all tests pass

Compile_hera.intel.log
RegressionTests_hera.intel.log
rt_full_verify_ecflow_after-moorthi-before-dycore-pr7.log

@climbfuji
Copy link
Collaborator Author

climbfuji commented Mar 12, 2020

Regression testing using rt_ccpp_dtc.conf on hera.intel

(1) Create (temporary) baseline: all tests pass

Compile_hera.intel.log
RegressionTests_hera.intel.log
rt_ccpp_dtc_create_ecflow_after-moorthi-before-dycore-pr7.log

(2) Verify against (temporary) baseline: all tests pass

Compile_hera.intel.log
RegressionTests_hera.intel.log
rt_ccpp_dtc_verify_ecflow_after-moorthi-before-dycore-pr7.log

@climbfuji
Copy link
Collaborator Author

climbfuji commented Mar 12, 2020

@junwang-noaa @DusanJovic-NOAA @SMoorthi-emc for your information, step 1 to update dtc/develop from master (CCPP) / develop (EMC). Turning on all previous CCPP regression tests (and adding the coupled wave-atm tests, but not yet Moorthi's new ras tests), all regression tests pass.

Next step will be to merge the dycore PR, Shan's changes and various other tiny PRs. But at least we know that at this stage, all IPD GFSv16 physics updates are correctly implemented in CCPP.

@junwang-noaa
Copy link

junwang-noaa commented Mar 12, 2020 via email

Copy link

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@climbfuji climbfuji merged commit cf3ba9a into NCAR:dtc/develop Mar 12, 2020
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Sep 24, 2020
Cleanup of radiation (clouds) - microphysics interaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants