Updating SCM codebase to work with CCPP physics and framework changes since the new year (plus updating SDFs and input namelists) #96
Conversation
…cheme; create 5 suites (control, control + GFDL MP, CPT advanced, csawmgshoc, GSD) for both active surface fluxes and prescribed surface fluxes; update case configuration files to point to new input namelists and for their names to reflect the suite being called; move case input namelists to /scm/etc/case_config/input_namelists; add scm/src/CCPP_typedefs.F90 to reflect latest changes to GFDL MP (not used in SCM since changes have to do with 32-bit running of fast GFDL MP, but kept for compiling purposes); modified GFS_typedefs.F90 and gmtb_scm_type_defs.f90 to work with latest commits of ccpp-physics
…rk and physics since the new year
|
Ok, I am trying this and NCAR/ccpp-physics#210 now ... |
| @@ -153,6 +159,7 @@ subroutine gmtb_scm_main_sub() | |||
| stop | |||
| end if | |||
|
|
|||
| physics%Model(i)%first_time_step = .true. | |||
There was a problem hiding this comment.
I believe the (i) should be a (j).
There was a problem hiding this comment.
Plus, that line should be two lines up before the "end do" of the do j=1, scm_state%n_cols ?
There was a problem hiding this comment.
Yep, this should also be outside of the time loop. No need to set this every time step. I just now created a new loop over (i=1 to n_cols) immediately above the time loop to fix this. Thanks for the catch.
There was a problem hiding this comment.
This may have just fixed it. Just ran two cases without error. You're a bonafide genius, Dom!
There was a problem hiding this comment.
It's running through in debug mode now as well. Passing on the compliments to my Macbook and the GNU compilers ...
…N for Thompson MP
…hemes; added SDFs corresponding to 'suite2' of the advanced physics test; added case configuration and namelists for suite2, added plot_config for suites 1,2,3 comparison
|
For reference, the following plots were generated with the following suites: These plots represent output from the TWP-ICE maritime deep convection case. Given that suite 3 is so different near the surface, I'm unsure that it is being run correctly. I'll need to double-check this later. Mean temperature, water vapor, cloud water over the active period: |
Updating SCM codebase to work with CCPP physics and framework changes since the new year (plus updating SDFs and input namelists)
This PR restores functionality of the SCM for working with ccpp-framework and ccpp-physics masters.
Includes the following code changes:
NOTE: As of this PR, there is still an issue related to Thompson-MP initialization that has not been debugged yet, so do not run with suite_SCM_GSD*.xml.