update SCM for adding CCPP dependencies to metadata and active attribute #199
Conversation
|
Note: The NOAA-EMC/fv3atm#153 PR does not appropriately apply "active" attribute for all diagnostic tendencies (du3dt, dv3dt, dt3dt, dq3dt). These WERE included in this SCM PR. |
Can you add the missing pieces to your DDT fv3atm PR? |
Yes. |
|
Thanks!
… On Sep 3, 2020, at 3:49 PM, grantfirl ***@***.***> wrote:
@climbfuji <https://github.com/climbfuji> Done: ***@***.*** <NOAA-EMC/fv3atm@65800dc>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#199 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RNBEIHHBJ2K6XPCDF3SEAFODANCNFSM4QVWMMUA>.
|
|
@climbfuji @llpcarson FYI, the master branch of SCM is "broken" until this PR is merged. |
Why? |
Broken in the sense that the latest master of SCM doesn't work with the latest master of ccpp-physics/framework due to the merged ccpp-table-properties stuff. |
But that is ok. gmtb-scm master points to specific hashes of ccpp-framework and ccpp-physics and those work, right? Nobody should blindly update each submodule/repository to the head of develop, master, ... and expect it to work. |
👍 Agreed, and yet people do. |
| @@ -85,134 +87,6 @@ | |||
| }, | |||
| } | |||
|
|
|||
| # Add all physics scheme dependencies relative to basedir - note that the CCPP | |||
There was a problem hiding this comment.
Getting rid of all of this is really nice.
|
@climbfuji Thanks for leading the way with the fv3atm PR! |
update SCM for adding CCPP dependencies to metadata and active attribute
This PR follows NOAA-EMC/fv3atm#153 in order to work with dependencies in the CCPP metadata and "active" attribute in the same.
Associated PRs:
NCAR/ccpp-framework#317
NCAR/ccpp-physics#483
This compiles/runs on Mac/GNU. Have not tested on other platforms.