Update for Mike Iacono's RRTMG cloud overlap code #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
reviewed
Aug 11, 2020
|
This code has been tested to build/compile/run with NCAR/ccpp-physics#487. I ran the TWPICE maritime deep convective case using the default cloud overlap namelist parameters and setting both SW and LW overlap methods to 4 and 5. All ran, with very minor differences for this case (see attached plots). |
This was referenced Aug 11, 2020
Yep, will do. I'll update the ccpp-physics submodule pointer when that PR is merged before merging this. |
|
@climbfuji @llpcarson Now that NOAA-EMC/fv3atm#157 is merged, this should be good to go to. |
dustinswales
pushed a commit
to dustinswales/ccpp-scm
that referenced
this pull request
May 16, 2022
…s_gjf Update for Mike Iacono's RRTMG cloud overlap code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR matches NOAA-EMC/fv3atm#157 for the updated cloud overlap for RRTMG from Mike Iacono (AER).
Associated PRs:
NOAA-EMC/fv3atm#157
NCAR/ccpp-physics#487
This effectively replaces #188.