Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix decomposition issue with cimin #742

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Conversation

junwang-noaa
Copy link
Collaborator

This PR is to fix the decomposition issue associated with cimin in radiation surface physics.

The following code sets cimin to the last cimin value from im, if decomposition changed, the cimin could get different value.

  do i=1,im
    if (lakefrac(i) > f_zero) then
      cimin = min_lakeice
    else
      cimin = min_seaice
    endif
  enddo

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent find, @junwang-noaa - thanks also for fixing this in RUC LSM. I will add @tanyasmirnova as reviewer.

@climbfuji climbfuji changed the title fix decomppsotion issue with cimin fix decomposition issue with cimin Sep 24, 2021
@SMoorthi-emc
Copy link
Collaborator

This is not just a decomposition issue - it is a real bug using the same cimin for all IM points!

Copy link
Collaborator

@tanyasmirnova tanyasmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this bug fix. Thank you, @junwang-noaa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants