Metadata bugfixes following CCPP standard name updates #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
This was referenced Sep 1, 2021
…data_bugfixes_following_ccpp_standard_name_updates
bluefinweiwei
approved these changes
Sep 9, 2021
climbfuji
deleted the
metadata_bugfixes_following_ccpp_standard_name_updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a few standard names used in the
dimensionsattributes. The old/invalid standard names came in with the latest gsl/develop merge. They went unnoticed, becauseccpp_prebuild.pyuntil now doesn't care about the dimensions, just the rank. This is going to chance soon with the new debugging feature that checks if active variables/arrays are allocated to the correct size (a separate, forthcoming PR).Fixes #723
Associated PRs:
#722
NOAA-EMC/fv3atm#379
ufs-community/ufs-weather-model#782
For regression testing, see ufs-community/ufs-weather-model#782