To add multi_gases and molecular diffusion options #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto udhmhj.04 merge without conflict.
with conflict fixed. Conflicts: physics/dcyc2.meta physics/moninedmf.meta physics/rrtmg_lw_post.F90 physics/rrtmg_sw_post.F90 physics/satmedmfvdif.meta physics/ugwp_driver_v0.F physics/ysuvdif.meta
This was referenced Jul 27, 2021
climbfuji
requested changes
Jul 27, 2021
XiaqiongZhou-NOAA
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
Change it back to the original.
climbfuji
approved these changes
Jul 29, 2021
|
@XiaqiongZhou-NOAA Can you give a quick update please where things stand with this PR? Are you still working on the associated GFDL_atmos_cubed_sphere changes? Thank you. |
|
Dom:
I am testing after merging the latest version of GFDL dev/emc to my
personal branch and will ask for the code review for
GFDL_atmos_cubed_sphere again.
Best
Kate
…On Fri, Sep 10, 2021 at 9:39 AM Dom Heinzeller ***@***.***> wrote:
@XiaqiongZhou-NOAA <https://github.com/XiaqiongZhou-NOAA> Can you give a
quick update please where things stand with this PR? Are you still working
on the associated GFDL_atmos_cubed_sphere changes? Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#712 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQE7UT4WG353ZIXNSDU55LUBIC65ANCNFSM5BCT5NFA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sounds good, Kate! Thanks for letting me know. |
climbfuji
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several field names related to multi_gases is changed.