features/ipd-setup-step-fast with SCM #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n physics caps object files
…n physics caps object files
ccpp-physics scm pgi support
…ks in one call) and SCM (runs over one block=column each time)
…atures/ipd-setup-step-fast-for-scm
climbfuji
pushed a commit
to climbfuji/ccpp-physics
that referenced
this pull request
Jan 16, 2021
Added initialization of pores and resid
dustinswales
pushed a commit
to dustinswales/ccpp-physics
that referenced
this pull request
Jun 12, 2023
MYNN fix for numerical stability issues with mixing snow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables running the features/ipd-setup-step-fast branch for FV3 with SCM by using different implementations of the time vary routines (running over each block=column for SCM, and over all blocks at once for FV3). The PR also contains the PGI changes that went into master already.
Some of the complexity we faced for running the time vary routines over each block separately in FV3 goes away for SCM, since the gcycle -> sfcsub routines are not called (these required the most changes). Hence, gcycle.f90 and sfcsub.F in this branch are the original versions that allow running the time vary steps over all blocks in one go for FV3, and as such cannot be used with SCM.