-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Fortran variables and CCPP standard names / long names of surface composites from ocean to water #609
Merged
climbfuji
merged 11 commits into
NCAR:master
from
climbfuji:rename_surface_composites_ocean_water
Apr 15, 2021
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8c60ce5
Remove/replace interstitial zorl composites with persistent versions
climbfuji f1d12c5
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into re…
climbfuji 20e1ae8
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into re…
climbfuji c8b70e9
physics/GFS_debug.*: add roughness length variables to GFS_checkland
climbfuji f4cf862
Cleanup formatting and unused variables in physics/GFS_suite_intersti…
climbfuji edc9194
Temporary commit: conditionally set zorlx variables to huge in GFS_su…
climbfuji bc78c25
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into re…
climbfuji 267748a
Rename Fortran variables and CCPP standard names / long names of surf…
climbfuji 3f953f5
physics/GFS_debug.F90: rename Sfcprop%zorlw to Sfcprop%zorlwav, remov…
climbfuji 7f42a8f
Merge branch 'remove_zorl_interstitial' of https://github.com/climbfu…
climbfuji 7f70536
physics/GFS_debug.*: rename land surface composite DDT members from _…
climbfuji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -160,4 +160,4 @@ | |
dimensions = () | ||
type = integer | ||
intent = out | ||
optional = F | ||
optional = F |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -448,4 +448,4 @@ | |
dimensions = () | ||
type = integer | ||
intent = out | ||
optional = F | ||
optional = F |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are zorlo and zorlw for ocean and water, respectively? Are they the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. I have not renamed the
Sfcprop
constituents yet, exactly because I wasn't sure what to do withSfcprop%zorlw
- make thisSfcprop%zorlwav
and useSfcprop%zorlw
for water? Would that be confusing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. zorlwav would be good for me. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shansun6 @SMoorthi-emc I renamed
Sfcprop%zorlw
toSfcprop%zorlwav
in #596, and then in this PRSfcprop%zorlo
toSfcprop%zorlw
. Doing this in two steps ensures that I am not mistakenly using the wrong values.