Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup radiation tendencies (standard names) #422

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 1, 2020

This PR addresses issue #179. It only deals with the clean up of the standard names as described in the issue, it does not remove the LTP (extra layers for radiation) logic.

Associated PRs:

#422
NCAR/fv3atm#34
NCAR/ufs-weather-model#32

For regression testing information, see NCAR/ufs-weather-model#32.

Copy link
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but Grant's more familiar with this issue

approved.

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although its been 16 months (!) since the issue was started, so my memory is certainly foggy WRT this. So now, the heating rates coming out of RRTMG are on radiation timesteps and levels, get converted to physics levels in the RRTMG post interstitial schemes (albeit within the Radtend DDTs), then used throughout the rest of the physics on the appropriate levels. My only nitpick is that I thought we agreed on using "timestep" rather than "time step". Doing a search on the previous version of GFS_typedefs.meta shows a ratio of like 4:1 using timestep over time step, but of course, these PRs will shift that.

@climbfuji
Copy link
Collaborator Author

This looks good to me, although its been 16 months (!) since the issue was started, so my memory is certainly foggy WRT this. So now, the heating rates coming out of RRTMG are on radiation timesteps and levels, get converted to physics levels in the RRTMG post interstitial schemes (albeit within the Radtend DDTs), then used throughout the rest of the physics on the appropriate levels. My only nitpick is that I thought we agreed on using "timestep" rather than "time step". Doing a search on the previous version of GFS_typedefs.meta shows a ratio of like 4:1 using timestep over time step, but of course, these PRs will shift that.

Argh. I missed that - I thought it was the other way round. It will be no problem to make this change as a quick follow up PR. Do we want to discuss this at the ccpp-framework meeting? I feel that this should be standardized across the organizations.

@climbfuji climbfuji merged commit f288626 into NCAR:dtc/develop Apr 2, 2020
@climbfuji climbfuji deleted the cleanup_radiation_tendencies branch June 27, 2022 03:09
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
…NCAR#422)

* Replace units 'various' with 'mixed', update several invalid units of non-physical quantities, fix units of humidity diagnostic variables
* Change units of relative humidity variables in CCPP metadata from 1 or none to frac, remove intent attributes from GFS_typedefs.meta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants