Coupled stochy fixes for precipitation #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update my fork with NCAR's master
pjpegion
requested review from
climbfuji,
grantfirl,
JulieSchramm and
llpcarson
as code owners
climbfuji
approved these changes
Mar 23, 2020
|
@climbfuji This does not change the current regression test since it only is an issue with the coupled model, and the regression tests are not running anything coupled yet. |
Of course - I should have known. |
|
Update 03/24/2020: this PR has been pulled into #417 and will be merged automatically as part of it. No need to close this PR, it will be flagged as merged automatically. |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
…effective radii computation from Thompson MP" and "Fix/improve logic for convective transportable tracers, add GFS_checktracer debugging routine, correct spelling "janic" --> "janjic", fix inconsistent types related with noahmp and log functions" (NCAR#416) * Add missing active attribute for one variable in ccpp/data/GFS_typedefs.meta * Correct spelling of janic in CCPP standard names, must be janjic * Remove invalid optional and intent attributes from DDT metadata in ccpp/data/GFS_typedefs.meta * Remove support for optional arguments from CCPP framework/metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request references #415, there was an inconsistency between the partition of the rain and snow and the rain/snow tendency that was later perturbed as part of SPPT.
The update to GFS_MP_generic.F90 makes these consistent.