Adding gsd drag suite to ccpp. #324
Conversation
mdtoy
requested review from
climbfuji,
grantfirl,
JulieSchramm and
llpcarson
as code owners
There was a problem hiding this comment.
I left a few comments and suggestions for improvements. Note also that once this PR and associated PRs are OK from the CCPP codeowners side, I will update them with the latest code in gmtb/develop and perform the metadata table conversions. @grantfirl @llpcarson
| real :: a1,a2,wsp | ||
| real :: H_efold | ||
|
|
||
| ! critical richardson number for wave breaking : ! larger drag with larger value |
There was a problem hiding this comment.
This is more of a question: Do any of these constants exist in FV3, and should they be imported from the host model? If not, should they be added on the host model side? Some of these could be namelist parameters, some actual physical constants? This isn't something we need to do right now, but worth keeping in mind.
|
|
||
| ! Interface variables | ||
| integer, intent(in) :: im, ix, km, imx, kdt, ipr, me, master | ||
| inteter, intent(in) :: gwd_opt |
There was a problem hiding this comment.
I don't think this code compiles. No need to fix, I will do this.
Need help from Dom to create new meta data file for ccpp/physics/physics/drag_suite.F90