fix divide by zero bug in module_bl_mynn.F90 #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joeolson42 We'd like a review to see if you think that this is OK. |
|
Note: for expedience, this PR has been merged into #264 and is tested together with the changes/PRs listed in there. |
|
This PR is being closed in favor of #264 where it was tested in RTs by @climbfuji . |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
) Use the GFDL dycore repository dev/emc. The GFDL dev/emc branch of dycore was synchronized with the GFDL master, which included the FV3 202101 upgrade except inline GFDL_MP : https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/releases/tag/FV3-202101-public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was discovered by @ligiabernardet using -fpe0 compiler flag with Intel 18 on Theia (during SCM testing).