Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add calls to CCPP-compliant physics, cleanup and optimize 2018/08/17 #144

Merged
merged 6 commits into from
Aug 20, 2018
Merged

Add calls to CCPP-compliant physics, cleanup and optimize 2018/08/17 #144

merged 6 commits into from
Aug 20, 2018

Commits on Aug 18, 2018

  1. physics/GFS_suite_interstitial.F90: add scheme GFS_suite_stateout_res… 

    …et, rename GFS_suite_update_stateout to GFS_suite_stateout_update; todo: replace DDTs
    @climbfuji
    climbfuji committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    f22ec4f View commit details
    Browse the repository at this point in the history

  2. physics/GFS_surface_generic.f90, physics/gmtb_scm_sfc_flux_spec.f90, … 

    …physics/sfc_diff.f, physics/sfc_drv.f, physics/sfc_nst.f: rename specific_humidity_at_lowest_model_layer to water_vapor_specific_humidity_at_lowest_model_layer (similar for specific_humidity_at_lowest_model_layer_for_diag)
    @climbfuji
    climbfuji committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    164c357 View commit details
    Browse the repository at this point in the history

  3. physics/h2ophys.f: remove unused argument h2op

    @climbfuji
    climbfuji committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    b305bab View commit details
    Browse the repository at this point in the history

  4. physics/ozphys.f: remove modules ozphys_pre and ozphys_post - no long… 

    …er needed because we are using Diag%dq3dt in ozphys instead of interstitial variable Interstitial%dq3dt
    @climbfuji
    climbfuji committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    b1917e5 View commit details
    Browse the repository at this point in the history

  5. physics/sfc_diag.f: operate on Stateout variables instead of Statein … 

    …variables; this is necessary because FV3's GFS_physics_driver calls sfc_diag twice, once with Statein and later with Stateout variables, and Stateout can be used in both places instead; it is also reasonable, since sfc_diag calculates output diagnostics that should be related to Stateout and not Statein

Also: add missing intent information for subroutine arguments, replace imported constants with arguments from CCPP
    @climbfuji
    climbfuji committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    cc92ce1 View commit details
    Browse the repository at this point in the history

  6. physics/sfc_sice.f: remove sfc_sice_pre, use Sfcprop(i)%{fice,tisfc,h… 

    …ice} instead of Interstitial%{cice,tice,zice} in sfc_sice, simplify sfc_sice_post
    @climbfuji
    climbfuji committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    4daa728 View commit details
    Browse the repository at this point in the history