Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUC LSM does not give b4b identical results through restarts following the fractional-landmask changes #261

Closed
climbfuji opened this issue Jun 6, 2019 · 1 comment
Closed

RUC LSM does not give b4b identical results through restarts following the fractional-landmask changes #261

climbfuji opened this issue Jun 6, 2019 · 1 comment
Assignees
@climbfuji @tanyasmirnova

Comments

@climbfuji
Copy link
Collaborator

The RUC LSM does no longer give bit-for-bit identical results after the fractional landmask changes from Shan & Ben were added to EMC Vlab and merged down to our code.

There are tests in rt_ccpp_gsd.conf that cover this test and that can be used to conduct the witch hunt

# creates 48h forecast for full GSD suite, amongst others:
./rt.sh -l rt_ccpp_gsd.conf -c fv3
# compares 48h forecast for full GSD suite with the baseline created above (trivial), but also compares 24h coldstart + 24h warmstart with those results:
./rt.sh -l rt_ccpp_gsd.conf -m
@climbfuji
Copy link
Collaborator Author

Fixed by #278

hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this issue Aug 3, 2022
@climbfuji
Wrapper PR for NCAR#261, NCAR#271, NCAR#268: zorl interstitial, ocn -…
0dde422 
…> wat, merra2 threading (NCAR#279)

* changed .gitmodules to point to merra2 ccpp/physics
* remove GFDL_atmos_cubed_sphere and ccpp-framework from .git module
* remove IPD gfsphysics
* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing
* Remove interstitial zorl composites
* Update .gitmodules and submodule pointer fpor ccpp-physics for code review and testing
* Remove or replace references to IPD in comments in atmos_model.F90
* Initialize Sfcprop%zorlx to clear_val instead of huge
* Update submodule pointer for ccpp-physics
* Rename Fortran variables and CCPP standard names / long names of surface composites from ocean to water
* Rename Sfcprop%zorlw to Sfcprop%zorlwav
* Rename Sfcprop%zorlo to Sfcprop%zorlw
* update submodule pointer for ccpp-physics
* Revert change to .gitmodules and update submodule pointer for ccpp-physics
Co-authored-by: anning.cheng <anning.cheng@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@climbfuji climbfuji

@tanyasmirnova tanyasmirnova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@climbfuji @tanyasmirnova