Add active attribute and update true/false logic in metavar.py, update example metadata table in metadata_table.py #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
deleted the
active_attribute_true_false_metavar_doc_metadata_table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings updates that were made in main (master) to feature/capgen, which should have happened much earlier. The idea is to simplifiy PR #391 and the follow-up merge back from main to feature/capgen. The burden of resolving merge conflicts will be on me when feature/capgen updates from this PR get pulled into #391.
Changes:
metadata_table.pyto includedependenciesandrelative_path, adjust indentsmetavar.py's variable classtrue/falselogic as discussed last year to avoid code duplicationThese changes have been tested, reviewed, and approved previously in various PRs (#205, #307, #317).