Enhancement/remove non living tracer cnt #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marbl_init_tracer_metadata() passes non_living_biomass_ecosys_tracer_cnt to marbl_init_non_autotroph_tracer_metadata(), where it is an intent out. However, the variable is only used in the non_autotroph_tracer_metadata() [it is not used after being returned], so I updated the interface accordingly. Next commit will look at how to remove it altogether.
What was previously marbl_init_non_autotroph_tracer_metadata has been renamed so that tracer is plural: marbl_init_non_autotroph_tracers_metadata; a new marbl_init_non_autotroph_tracer_metadata routine has been introduced for changing the metadata one tracer at a time. This removes the need for non_living_biomass_ecosys_tracer_cnt, which was implicitly requiring that the non-living biomass tracers had tracer indices 1 - N. Also fixed a typo in an error traceback.
|
If the comparison At that point, I call into question the need for (and usefulness of) the |
Removed a couple of un-necessary arguments from the subroutine interface, which also let me remove an associate statement in marbl_init_non_autotroph_tracers_metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
non_living_biomass_ecosys_tracer_cntvariable (see issue #137).Testing: verified that the tracer names and metadata did not change with this refactor by running a single POP CECO (+ciso) comparison test on both Cheyenne (intel 17) and Hobart (nag); this testing did catch some initial typos, and one of the errors flagged (I had accidentally changed the
ALKtracer toalk) also caught a typo in a MARBL error traceback.