Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
283 weekly roundup #360
283 weekly roundup #360
Changes from all commits
41b85bc
c6ba671
7690eac
18ad81a
93d155a
79b6571
b1f2285
61664ac
5bf29b2
fc927d8
2ceac29
6463c54
65d0477
9e150d3
7c84a7f
6aaf897
e3857fd
4eefb3a
5bdb43d
d45f32f
89765db
8b826e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to root ourselves to UTC here with
datetime.datetime.now(datetime.timezone.utc)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly. @jordanpadams ?
Current behaviour is to return data for the preceding Mon-Sun week, referenced to the tz of the host on which doi-service is running.
Your judgement call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nutjob4life @alexdunnjpl doesn't matter. weekly-ish is fine