wallet-ext: hide dapp connection status when not connected #4720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* showing `not connected` without a further explanations in a tooltip seems to be confusing * also when the active tab is the extension itself (in expanded mode) it doesn't seem correct
pchrysochoidis
requested review from
gegaowp,
Jibz1,
Jordan-Mysten and
mystie711
|
💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3085452374#artifacts |
gegaowp
approved these changes
Sep 19, 2022
pchrysochoidis
deleted the
pc-wallet-ext-4696-apps-connected-indicator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not connectedwithout a further explanations in a tooltip seems to be confusingScreen.Recording.2022-09-19.at.13.27.08.mov
part #4696