Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bridge] remove test-cluster's dependency on sui-bridge crate #19840

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

longbowlu
Copy link
Contributor

@longbowlu longbowlu commented Oct 14, 2024

Description

as title. It also removes the transitive dependency of other crates on sui-bridge.

Test plan

tests


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 3:44am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 3:44am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 3:44am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 3:44am

@longbowlu longbowlu changed the title Lu/bridge cluster rework [bridge] remove test-cluster's dependency on sui-bridge crate Oct 15, 2024
@longbowlu longbowlu marked this pull request as ready for review October 15, 2024 05:23
Copy link
Contributor

@patrickkuo patrickkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this changes, this will resolve the cyclic dependency issues I had earlier.

@longbowlu longbowlu merged commit 31b15dd into main Oct 16, 2024
50 checks passed
@longbowlu longbowlu deleted the lu/bridge-cluster-rework branch October 16, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants