Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe aliasing in rust after adding first federation #933

Open
TonyGiorgio opened this issue Jan 3, 2024 · 1 comment
Open

Unsafe aliasing in rust after adding first federation #933

TonyGiorgio opened this issue Jan 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working fedimint

Comments

@TonyGiorgio
Copy link
Contributor

TonyGiorgio commented Jan 3, 2024

recursive use of an object detected which would lead to unsafe aliasing in rust

I think this is because how I'm swapping in GlueDB after it inits a federation for the first time if none existed. Doesn't seem to hurt anything but probably not safe. A better approach would be to empty init GlueDB but do not start it until a federation is added.

@TonyGiorgio TonyGiorgio added bug Something isn't working fedimint labels Jan 3, 2024
@TonyGiorgio TonyGiorgio self-assigned this Jan 3, 2024
@TonyGiorgio
Copy link
Contributor Author

This is happening somewhere in FederationClient::new but only when adding for the first time. But it's happening either kind of inconsistently or the error log is showing up in different places sometimes. Hard to tell but nothing important I think. Postponing for later, nothing is presenting itself as a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fedimint
Projects
None yet
Development

No branches or pull requests

1 participant