Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate usage of scikit-video at the backend, because of it's development being stagnant #13

Closed
MrinalJain17 opened this issue Sep 4, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@MrinalJain17
Copy link
Owner

scikit-video should not be used for reading the videos as the development/maintenance of the library seems to be quite stagnant (based on the repository's activity)

Instead, after considering a few alternatives, ImageIO seems to be suitable for usage, since most of the functionality provided by scikit-video is available in ImageIO (not directly though). This would help in making the transition simple and more efficient (hopefully).

Further, the reason for this change will also be justified by relevant tests and performance comparisons.

Any suggestions/improvements are welcome 😄

@MrinalJain17 MrinalJain17 added enhancement New feature or request high priority labels Sep 4, 2018
@MrinalJain17 MrinalJain17 self-assigned this Sep 4, 2018
@MrinalJain17 MrinalJain17 removed this from In progress in Improvements and Enhancements Sep 12, 2018
@MrinalJain17
Copy link
Owner Author

As of now, ImageIO is not able to provide better performance results (particularly when resizing videos and converting them to grayscale). ImageIO also uses ffmpeg as their backend, and are planning to improve their plugin/create a new one for reading/writing videos.

So, work on this issue will begin after this plugin is introduced in the upcoming release of ImageIO.

@MrinalJain17 MrinalJain17 added question Further information is requested and removed high priority labels Sep 12, 2018
@MrinalJain17
Copy link
Owner Author

The new backend used would be ffmpeg-python.
Basically, mydia will act as a wrapper around the "filter" functionality of ffmepg-python for frame extraction, grayscale conversion, and frame resizing.

Also, after conducting few internal tests, this approach is ~6x faster that scikit-video (especially when the number of frames to be extracted is relatively small).

The next release (mydia 2.0.0) will use ffmpeg-python as its backend.

For initial changes, follow 5a488b7

@MrinalJain17 MrinalJain17 reopened this Sep 19, 2018
@MrinalJain17 MrinalJain17 removed the question Further information is requested label Sep 19, 2018
@MrinalJain17 MrinalJain17 moved this from In progress to Done in Improvements and Enhancements Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant