Code Cleanup (inner function related)

[benjaminleroy]

We need to standardize the following:

• 1. change all lon variables to long (as of 6 September 2018)
• 2. make the input parameters lon = 1, lat = 2 into the common c_position = 1:2 (just make a decision on which should be done) Ruling: now use position
• 3. change the names of things from credible to prediction
• 4. Change bubble_CI notation to spherical
• 5. correct spherical and delta ball ordering of lat and lon (incorrect)
  • 5.1 spherical functions: bubble_ci_from_tclist -> ggvis_bubble_data
  • 5.2 delta ball functions: delta_ball_wrapper -> ggvis_delta_ball_contour
• 6. For PBs should use parameter "alpha" not alpha_level to express the associated alpha level (to make 1-alpha PBs). Also alpha_ci_level should then be "alpha_ci".

[benjaminleroy]

@Mr8ND was this done?

[Mr8ND]

No I do not believe it was.

[benjaminleroy]

@RobinMDunn, not sure you've seen this list - but just figured I'd make sure you were aware

[RobinMDunn]

Got it, thanks!