chore: handle offline mode more graceful #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
added
Status: Actionable
skaldarnar
commented
Jun 30, 2023
Comment on lines
45
to
49
| if (e.getResponseCode() == -1) { | ||
| // no internet connection, do nothing | ||
| } else { | ||
| e.printStackTrace(); | ||
| } |
There was a problem hiding this comment.
Hm, PMD says this is bad, and instead we should do
Suggested change
| if (e.getResponseCode() == -1) { | |
| // no internet connection, do nothing | |
| } else { | |
| e.printStackTrace(); | |
| } | |
| if (e.getResponseCode() != -1) { | |
| // -1 would indicate no internet connection, in which case the exception is expected | |
| // and should just be ignored. In all other cases, this is indeed exceptional behavior | |
| // and we print the stacktrace. | |
| e.printStackTrace(); | |
| } |
I personally prefer the variant with the empty if branch, because I think the reasoning for the control flow is more comprehensible.
There was a problem hiding this comment.
I believe that your variant is fine. I'd say we can add a nopmd comment: https://pmd.github.io/pmd/pmd_userdocs_suppressing_warnings.html#nopmd-comment
The example they give even is an empty if statement 😁
There was a problem hiding this comment.
Thanks for adding the //NOPMD comments 👍
|
Without this change (offline): With this change (offline): With this change (online): |
jdrueckert
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Instead of blindly logging the stacktrace of exceptions the launcher now checks for an
HTTPExceptionand whether the status code is -1, indiciating a network issue, for instance, when running offline.Thus, we should only log in exceptional cases.
This does not affect any functionality of the launcher when run offline, though.
How to test
Start the launcher when offline and observe the logs. There should be less stacktraces printed from the GitHub repository adapter.
Outstanding before merging
Nothing.