Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused code #697

Merged
merged 2 commits into from
Jun 30, 2023
Merged

chore: Remove unused code #697

merged 2 commits into from
Jun 30, 2023

Conversation

skaldarnar
Copy link
Member

Contains

  • chore: remove unused function 'confirmSourcesOverwrite'
  • chore: remove unused imports

How to test

The code was unused, so I hope no test needed.

Outstanding before merging

Nothing.

@skaldarnar skaldarnar added this to the v4.8.0 milestone Jun 30, 2023
@skaldarnar skaldarnar added Status: Actionable An issue or task that can immediately be worked on Type: Maintenance Maintenance or chores not adding new features or fixing bugs. labels Jun 30, 2023
jdrueckert
jdrueckert approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't test launcher still compiles, though, please quickly check before merging.

@jdrueckert
Copy link
Member

Test comment to check if discord integration works again.

@skaldarnar
Copy link
Member Author

skaldarnar commented Jun 30, 2023 •
edited
Loading

Didn't test launcher still compiles

I trust our CI to check that 😉

@skaldarnar skaldarnar merged commit 0fc550b into master Jun 30, 2023
@skaldarnar skaldarnar deleted the chore/remove-unused-code branch June 30, 2023 17:20
@skaldarnar skaldarnar mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrueckert jdrueckert jdrueckert approved these changes

Assignees
No one assigned
Labels
Status: Actionable An issue or task that can immediately be worked on Type: Maintenance Maintenance or chores not adding new features or fixing bugs.
Projects
None yet
Milestone
v4.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@skaldarnar @jdrueckert