Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated the download URL #691

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Conversation

anshukrs
Copy link
Contributor

@anshukrs anshukrs commented Apr 4, 2023

@jdrueckert
Copy link
Member

jdrueckert commented Apr 6, 2023

Thanks for the contribution @anshukrs!
Approved, but we'll need to fix the push validation action first, before merging it. I'll have a quick look now, but if it's nothing trivial, it will need to wait until tomorrow.

PS: I added "Fixes <issue-nr>" which will instruct GitHub to auto-close the referenced issue once the PR gets merged. Also, I adjusted the PR title to match our guidelines.

@jdrueckert jdrueckert changed the title #690 Updated the download URL fix: updated the download URL Apr 6, 2023
@jdrueckert
Copy link
Member

jdrueckert commented Apr 6, 2023

Interestingly, for other PRs the Test Report Upload works (see here for example), but on yours it doesn't... Guess I'll need to dig some more tomorrow or on the weekend.

@jdrueckert
Copy link
Member

Seems like the GitHub Action has some issues with PRs coming from forks 🙄
We'll need to either debug and fix the action or divert to using another one. I'll create an issue for that.

Until we get to that, I believe it's fine to merge this PR without the action succeeding - after all it's a minor change that doesn't touch any of the launcher's logic, etc. So thank you for the contribution @anshukrs and congratulations to your first launcher PR being merged 👏

@jdrueckert jdrueckert merged commit a431c4a into MovingBlocks:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix launcher link to launcher download on website
2 participants